@angular-devkit: Filter project names #739
Conversation
|
Is there an issue with AppVeyor ? This PR doesn't impact NgPackagr Build, and test-large is ok on my computer. |
|
The test timeouts were recently adjusted. Try rebasing against master to pick up the changes. |
This commit is just a first example for angular#10369, following the discussion started in angular/devkit#730. angular/devkit#739 would be needed. This example would also require some evolutions on @angular-devkit/architect, but I'm sure there is a way to do this.
|
@filipesilva So, as I said in #730 (comment), this PR is, in my opinion, still relevant even if it's not the solution for #730. In fact, in any mono-repository mixing apps and libs, the CI could be tricky to manage, as we need two separated workflows : one for applications, and one for libraries. When using a unique versioning for a set of libraries, bumping version number, testing, building and releasing should be done for a set of libraries at once. It could be for all the libraries in the project, or for a specific subset (for example, all the libraries associated with a given scope (#646 should help a lot on this thanks to @Brocco ). By adding a filtering solution, we could, instead of just running a bunch of ng commands, run the target on a specific subset of our choice, which should lead to better performances and readability. Even for applications, we have some cases where we could have specific sets which should have their own CI process separated from the others (for example, a bunch of applications used for one domain). For now, we have to write some scripts around angular-cli in order to do this kind of thing, what seems to me to be a cheap workaround. angular/angular-cli#10397 is just a first usage example, which would need some more work. |
nweldev
changed the title
Permit to filter the list of projects names in a Workspace thanks to a new, optionnal, filter method.
test the previously added feature
TargetSpecifier now permit to use a projectFilter as defined in angular-devkit/core in bb6638
As some of the tests introduced by a6767dc was based on the fact that the workspaceJson had only one project, add the according updates to customWorkspaceJson in order to fix the tests.
This commit is just a first example for angular#10369, following the discussion started in angular/devkit#730. angular/devkit#739 would be needed. This example would also require some evolutions on @angular-devkit/architect, but I'm sure there is a way to do this.
|
Sorry @noelmace - this got lost when we moved back to the angular/angular-cli repo. If you still think this pull request is relevant, could you please re-base on that repo and open a new PR there? Thanks and sorry for the extra churn. |
Permit to get only the required project names.
This should permit to add some new behaviours in angular-cli to complete the --project option, for example a new --libraries-only option for the build, lint and test commands.