Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

fix(@ngtools/webpack): Validate wildcard path replacements #751

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions packages/ngtools/webpack/src/paths-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,33 @@ export function resolveWithPaths(
replacement = prefix + pathMapOptions[0].partial + suffix;
}

request.request = path.resolve(compilerOptions.baseUrl || '', replacement);
callback(null, request);
replacement = path.resolve(compilerOptions.baseUrl || '', replacement);

return;
if (host.fileExists(replacement)) {
// Found a definite match
request.request = replacement;
callback(null, request);
return;
}
else {
// Could be an extensionless import that TS can resolve?
const moduleResolver = ts.resolveModuleName(
replacement,
request.contextInfo.issuer,
compilerOptions,
host,
cache,
);

const moduleFilePath = moduleResolver.resolvedModule
&& moduleResolver.resolvedModule.resolvedFileName;

if (moduleFilePath) {
request.request = moduleFilePath;
callback(null, request);
return;
}
}
}

const moduleResolver = ts.resolveModuleName(
Expand Down