This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Fix 10396 #817
Merged
Fix 10396 #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
force-pushed
the
fix-10396
branch
2 times, most recently
from
367786e to
169a426
Compare
filipesilva
suggested changes
Apr 30, 2018
|
|
||
| const polyfills = app.polyfills || defaults.polyfills; | ||
| if (!filesAstNode) { | ||
| appendPropertyInAstObject(recorder, tsCfgAst, 'files', [polyfills]); |
There was a problem hiding this comment.
If files does not exist, it shouldn't be created. Creating a files array will implicitly exclude all files that are not in the array.
filipesilva
approved these changes
Apr 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix angular/angular-cli#10396