This repository was archived by the owner on Apr 4, 2025. It is now read-only.
fix(@angular-devkit/schematics): add support for BOM to UpdateRecorder #862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
reviewed
May 8, 2018
| super(entry); | ||
| } | ||
|
|
||
| insertLeft(index: number, content: Buffer | string) { |
There was a problem hiding this comment.
Is index in terms of byte offsets or character offsets? Also is the string for content converted into the encoding specified by the BOM? It might be useful longer term to have both a BinaryUpdateRecorder and TextUpdateRecorder.
There was a problem hiding this comment.
Indeed. Right now it's in term of binary offset. I'm still unsure how we want to approach this problem.
There was a problem hiding this comment.
We need an UpdateBuffer that supports text instead of buffers. That's not a huuuuge challenge, but something we should defer to the libraries (maybe?).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes angular/angular-cli#10644