Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

fix(@schematics/angular): e2e should use the name #930

Merged
merged 1 commit into from
May 17, 2018
Merged

fix(@schematics/angular): e2e should use the name #930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/schematics/angular/application/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ export default function (options: ApplicationOptions): Rule {
name: `${options.name}-e2e`,
relatedAppName: options.name,
rootSelector: appRootSelector,
prefix: options.prefix || 'app',
};
if (options.projectRoot !== undefined) {
e2eOptions.projectRoot = 'e2e';
Expand Down
2 changes: 1 addition & 1 deletion packages/schematics/angular/e2e/files/src/app.e2e-spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ describe('workspace-project App', () => {

it('should display welcome message', () => {
page.navigateTo();
expect(page.getParagraphText()).toEqual('Welcome to <%= prefix %>!');
expect(page.getParagraphText()).toEqual('Welcome to <%= relatedAppName %>!');
});
});
4 changes: 0 additions & 4 deletions packages/schematics/angular/e2e/schema.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,4 @@ export interface Schema {
* The name of the app being tested.
*/
relatedAppName: string;
/**
* The prefix to apply.
*/
prefix?: string;
}
7 changes: 0 additions & 7 deletions packages/schematics/angular/e2e/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@
"relatedAppName": {
"description": "The name of the app being tested.",
"type": "string"
},
"prefix": {
"type": "string",
"format": "html-selector",
"description": "The prefix to apply to generated selectors.",
"default": "app",
"alias": "p"
}
},
"required": [
Expand Down