Skip to content
This repository was archived by the owner on Apr 4, 2025. It is now read-only.

Build Optimizer ES2015 fixes #981

Merged
merged 4 commits into from
May 30, 2018
Merged

Build Optimizer ES2015 fixes #981

merged 4 commits into from
May 30, 2018

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented May 29, 2018

These fixes should allow projects using "target": "es2015", in tsconfig.json to create a working build when using Build Optimizer.

For a new project, using a production build, the main bundle size is:

  • ES5: with build optimizer 155 kB, without build optimizer 255 kB (-39%)
  • ES2015: with build optimizer 147 kB, without build optimizer 208 kB (-29%)

For Angular.io, using a production build, the main bundle size is:

  • ES5: with build optimizer 479 kB, without build optimizer 732 kB (-34%)
  • ES2015: with build optimizer 435 kB, without build optimizer 626 kB (-30%)

The improvements are less dramatic but still there.

@filipesilva filipesilva requested a review from clydin as a code owner May 29, 2018 09:31
@filipesilva
Copy link
Contributor Author

AIO doesn't show console errors but doesn't seem to load content properly with these fixes. Investigating.

@filipesilva
Copy link
Contributor Author

The problem in AIO seems to be dropped RxJs code: ReactiveX/rxjs#3756

I am not sure why this is not a problem with Build Optimizer when using the ES5 version of RxJs.

@filipesilva
Copy link
Contributor Author

The issue with AIO was clarified on ReactiveX/rxjs#3756 and is now addressed in this PR.

clydin
clydin previously approved these changes May 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants