This repository was archived by the owner on Apr 4, 2025. It is now read-only.
fix(@schematics/angular): Fix usage of sourceRoot configuration value #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
suggested changes
May 31, 2018
| options.path = `/${project.root}/src/${projectDirName}`; | ||
| options.path = project.sourceRoot | ||
| ? `/${project.sourceRoot}/${projectDirName}` | ||
| : `/${project.root}/${project.sourceRoot || 'src'}/${projectDirName}`; |
There was a problem hiding this comment.
The code section inside this if block appears to be repeated in most schematics. It probably should be pulled out and introduced as a utility function to simplify any changes/fixes in the future.
There was a problem hiding this comment.
Good idea... refactored.
Brocco
force-pushed
the
custom-source-root
branch
from
1a16de7 to
4a2bcd9
Compare
clydin
approved these changes
May 31, 2018
hansl
approved these changes
Jun 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes angular/angular-cli#10653