fix vulnerable dependencies #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
marked v0.7.0 has now been released, with another ReDoS fix and a few more breaking changes. It would be great to see this merged soon, as all of my repos are currently failing |
The previous version of `marked` was vulnerable to a [ReDoS](https://app.snyk.io/vuln/SNYK-JS-MARKED-174116) attack. BREAKING CHANGES There are a few relevant breaking changes with this latest version of `marked`. This only affects usage of the `renderMarkdown()` service and the `marked` nunjucks filter. Take a look through the [marked release notes](https://github.com/markedjs/marked/releases) and check if this affects you. Fixes angular#280
|
Working on it... there is also the |
Using `shelljs.exec()` has been flagged as a security issue, so this commit removes it as a dependency and uses `child_process.spanSync()` instead.
petebacondarwin
force-pushed
the
issue-280
branch
from
a70d012 to
18a1c0b
Compare
petebacondarwin
changed the title
marked to avoid vulnerability
|
Released as 0.28.0 |
|
Thanks! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of
markedwas vulnerable to aReDoS
attack.
BREAKING CHANGES
There are a few relevant breaking changes with this latest version of
marked.This only affects usage of the
renderMarkdown()service and themarkednunjucks filter. Take a look through the
marked release notes and
check if this affects you.
Fixes #280