Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Remove duplicate symbol "assert" #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

caitp
Copy link
Contributor

@caitp caitp commented May 22, 2014

Fixes #14

Review on Reviewable

@caitp
Copy link
Contributor Author

caitp commented May 22, 2014

This is just a first attempt at this, it's probably still broken

@caitp
Copy link
Contributor Author

caitp commented May 22, 2014

So, this is still broken because tests, and possibly more of the library, need to be updated to match the current watchtower.

@EisenbergEffect can you help me with this tomorrow? I think that this kind of break is something that's likely to continue to occur in the modular architecture, too

@EisenbergEffect
Copy link
Contributor

I can take care of it. I'm wondering...should expressionist be dependent on watchtower? Or should we move the WatchParser class into watchtower and reverse the dependency?

@caitp
Copy link
Contributor Author

caitp commented May 22, 2014

the way it is now, theoretically watchtower should be agnostic about expression languages, so I think that's the main reason why watchparser lives in expressionist. But it's true that it is awkward and will likely lead to breaking.

Lets talk to Miško about it and see what he thinks (in a few days)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate symbol assert causes SyntaxError in strict mode
2 participants