Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FxLayoutAlign="flex-end" renders as flex-start #232

Closed
cellsheet opened this issue Mar 23, 2017 · 3 comments · Fixed by #239
Closed

FxLayoutAlign="flex-end" renders as flex-start #232

cellsheet opened this issue Mar 23, 2017 · 3 comments · Fixed by #239
Labels
bug has pr A PR has been created to address this issue
Milestone
v2.0.0-beta.7

Comments

@cellsheet
Copy link

I'm wrapping my html in a div that looks something like <div class="flex" fxLayout="column" fxLayoutAlign="flex-end center" fxLayoutGap="10px"> but when I go to inspect element, justify-content is set to flex-start and not flex-end
@xban1x
Copy link

xban1x commented Mar 24, 2017

Use "end center"

@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.7 milestone Mar 24, 2017
@ThomasBurleson
Copy link
Contributor

While not a recommended usage, we should support the flexbox CSS versions also.

ThomasBurleson added a commit that referenced this issue Mar 28, 2017
@ThomasBurleson
fix(fxLayoutAlign): support flex-start and flex-end options
4076cf4 
Current API translates `start` and `end` to `flex-start` and `flex-end` respectively.
The API should also support the raw flex-<xxx> values.

Fixes #232.
@ThomasBurleson ThomasBurleson mentioned this issue Mar 28, 2017
Merged
@ThomasBurleson ThomasBurleson added the has pr A PR has been created to address this issue label Mar 28, 2017
ThomasBurleson added a commit that referenced this issue Mar 28, 2017
@ThomasBurleson
fix(fxLayoutAlign): support flex-start and flex-end options
1913570 
Current API translates `start` and `end` to `flex-start` and `flex-end` respectively.
The API should also support the raw flex-<xxx> values.

Fixes #232.
tinayuangao pushed a commit that referenced this issue Mar 29, 2017
@ThomasBurleson @tinayuangao
fix(fxLayoutAlign): support flex-start and flex-end options (#239)
eb5cb9f 
Current API translates `start` and `end` to `flex-start` and `flex-end` respectively.
The API should also support the raw flex-<xxx> values.

Fixes #232.
karlhaas pushed a commit to karlhaas/flex-layout that referenced this issue May 3, 2017
@ThomasBurleson @karlhaas
fix(fxLayoutAlign): support flex-start and flex-end options (angular#239
7151f48 
)

Current API translates `start` and `end` to `flex-start` and `flex-end` respectively.
The API should also support the raw flex-<xxx> values.

Fixes angular#232.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug has pr A PR has been created to address this issue
Projects
None yet
Milestone
v2.0.0-beta.7
Development

Successfully merging a pull request may close this issue.

fix(fxLayoutAlign): support flex-start and flex-end options angular/flex-layout
3 participants
@ThomasBurleson @cellsheet @xban1x