Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

docs(breakpoints): add guide for adding custom breakpoints #609

Closed
CaerusKaru opened this issue Feb 11, 2018 · 3 comments
Closed

docs(breakpoints): add guide for adding custom breakpoints #609

CaerusKaru opened this issue Feb 11, 2018 · 3 comments
Assignees
Labels
docs enhancement P5 Low-priority issue that needs consideration

Comments

@CaerusKaru
Copy link
Member

Currently the only way to add custom breakpoints is to provide the BREAKPOINTS token manually. If a user wants to include the default breakpoints, they have to specifically redeclare them, which might not be obvious.

The proposed solution is to add a new CUSTOM_BREAKPOINT multi token that can be concatenated to the main breakpoints array (taken from the BREAKPOINTS token) on startup.

@CaerusKaru CaerusKaru added enhancement P5 Low-priority issue that needs consideration labels Feb 11, 2018
@CaerusKaru CaerusKaru added this to the Backlog milestone Feb 11, 2018
@CaerusKaru CaerusKaru self-assigned this Feb 11, 2018
@CaerusKaru
Copy link
Member Author

Looks like we already have CUSTOM_BREAKPOINTS_PROVIDER_FACTORY, so this issue is going to track adding a guide for custom breakpoints.

@CaerusKaru CaerusKaru changed the title feat(breakpoints): add ability to tack on breakpoints docs(breakpoints): add guide for adding custom breakpoints Feb 11, 2018
@CaerusKaru
Copy link
Member Author

This has been added as part of #670, closing.

@CaerusKaru CaerusKaru removed this from the Backlog milestone Dec 19, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs enhancement P5 Low-priority issue that needs consideration
Projects
None yet
Development

No branches or pull requests

1 participant