Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

fxFlex not fill the parent in v6.0.0-beta.15 #749

Closed
kyoz opened this issue May 23, 2018 · 4 comments
Closed

fxFlex not fill the parent in v6.0.0-beta.15 #749

kyoz opened this issue May 23, 2018 · 4 comments

Comments

@kyoz
Copy link

kyoz commented May 23, 2018

Bug, feature request, or proposal:

After i upgrade to angular 6, i have to update rxjs and flex-layout too. And with flex-layout 6.0.0-beta-15 it seem my UI are all broke 😢

I also know that there are breaking changes, i'v also tried some workaround but it all not work 😭

With

[fxFlex] {
  display: flex; 
}

it seem fix some problem, but sometime i use fxFill too, and fxFill is still facing similar problem. is there any way i can fix it ?

What is the expected behavior?

Back in 5.1.1. This is most used layout on our page
https://stackblitz.com/edit/ng-flex-layout-5

What is the current behavior?

And now it become this:
https://stackblitz.com/edit/ng-flex-layout-6
(maybe the height or min-height is the problem)

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

os: ubuntu 18.04, OSX high sierra
browser: chrome
angular: 6.0.2
flex-layout: 6.0.0-beta.15
typescript: 2.7.2

@julianobrasil
Copy link

julianobrasil commented May 23, 2018

@banminkyoz, there was a breaking change over here: #670

Unfortunately I would suggest you to do what you have already done.

@kyoz
Copy link
Author

kyoz commented May 23, 2018

Thanks @julianobrasil , as read those reference issues i find out the way to make my app back to original state. 😄

[fxFlex] {
  display: flex; 
  flex-direction: row;
}
*[fxlayout='column'] > *[fxFlex] {
  flex-basis: 1e-9px !important;
}

@CaerusKaru
Copy link
Member

This will be fixed by 6.0.0-beta.16 and is tracked by #728

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants