Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix: add generic type for ModuleWithProviders #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CaerusKaru
Copy link
Member

No description provided.

@CaerusKaru
Copy link
Member Author

Ref: angular/angular#33217

@CaerusKaru
Copy link
Member Author

cc @IgorMinar @brandonroberts @kara

@clark-stevenson
Copy link

Hey guys, would it be possible to take a look at this PR? When trying to update to Angular 9, I get this error and was going to write a ticket but I guess @CaerusKaru has fixed it here (appreciated!)

@brandonroberts
Copy link
Contributor

I don't have access to merge anything here, so it will have to be merged before I can publish a release

@aparna999
Copy link

cc @IgorMinar @brandonroberts @kara
Any plans to release this fix? Thanks. Aparna

@baburner
Copy link

cc @IgorMinar @brandonroberts @kara
Any plans to release this fix? Thanks. Aparna

Might be good to know! Otherwise we have to find a replacement for the in-memory-web-api when migrating to Angular 9

(And we can't wait forever ;) )

@brandonroberts
Copy link
Contributor

Thanks for your patience.

I'll merge it locally, publish a new version, and open a PR for those changes. I'll update here when it's done

@brandonroberts
Copy link
Contributor

0.10.0 has been published to npm with #251 containing those changes

@aparna999
Copy link

0.10.0 has been published to npm with #251 containing those changes

Thank you. Works now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants