Fix undefined variable testFn #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this causes jasminewd2 to be incompatible with strict mode.
sjelin
reviewed
Nov 18, 2016
| var async = fn.length > 0; | ||
| testFn = fn.bind(this); | ||
| var async = fn.length > 0, | ||
| testFn = fn.bind(this); |
There was a problem hiding this comment.
I'd prefer:
var async = fn.length > 0;
var testFn = fn.bind(this);There was a problem hiding this comment.
I prefer it that way too. Will change.
I only submitted it that way because I looked for other variable definitions and it seems there's no consistent style being used in this file.
sjelin
approved these changes
Nov 21, 2016
cnishina
pushed a commit
to cnishina/jasminewd
that referenced
this pull request
Jan 6, 2017
* Fix undefined variable testFn this causes jasminewd2 to be incompatible with strict mode. * fix variable definition style
cnishina
pushed a commit
that referenced
this pull request
Jan 6, 2017
* Fix undefined variable testFn this causes jasminewd2 to be incompatible with strict mode. * fix variable definition style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this causes jasminewd2 to be incompatible with strict mode.