feat(init): ***breaking change*** pass webdriver instance into init()…
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjelin
changed the title
init()…
sjelin
force-pushed
the
noWDInstance
branch
2 times, most recently
from
dc58c3f to
3876a16
Compare
juliemr
reviewed
Jan 21, 2017
| usingServer('http://localhost:4444/wd/hub'). | ||
| withCapabilities({browserName: 'chrome'}). | ||
| build(); | ||
| require('jasminewd2').init(webdriver.promise.controlFlow(), webdriver); | ||
|
|
There was a problem hiding this comment.
We should probably still show this webdriver step, since we use the global driver below.
sjelin
commented
Jan 21, 2017
| @@ -12,16 +12,15 @@ | |||
| ], | |||
| "author": "Julie Ralph <ju.ralph@gmail.com>", | |||
| "dependencies": { | |||
| "jasmine": "2.4.1", | |||
| "selenium-webdriver": "3.0.1" | |||
| "jasmine": "2.4.1" | |||
There was a problem hiding this comment.
We never actually require('jasmine') in index.js, so we could make this a devDependency. I'm not sure explicitly depending on jasmine actually does anything for us.
There was a problem hiding this comment.
Hm. I think that's a fair point, it only enabled conflicts having it there.
|
@juliemr all comments addressed |
juliemr
approved these changes
Jan 21, 2017
…)` instead of using `require()`
So where as before you would write:
```js
require('jasminewd').init(webdriver.promise.controlFlow());
```
Now you will write:
```js
require('jasminewd').init(webdriver.promise.controlFlow(), webdriver);
```
This removes the dependency on `selenium-webdriver` and protects jasminewd from having a different
webdriver instance than Protractor, which could be a huge problem if they had different control flow
settings.
This is a breaking change because it changes the API for the `init` function.
I also removed the dependency on jasmine, which didn't do anything anyway. Maybe it should have
been a peerDependency but those are deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… instead of using
require()This removes the dependency on
selenium-webdriverand protects jasminewd from having a differentwebdriver instance than Protractor, which could be a huge problem if they had different control flow
settings.
This is a breaking change because it changes the API for the
initfunction.