This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Update to Angular CLI v6 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the following: * Running ng update @angular/cli, which updates the project config file, karma config, etc. * * Changing the build defaults to `aot: true` and `sourceMap: false` * Updating the stackblitz versions for Angular 6
josephperrott
approved these changes
Apr 27, 2018
| @@ -51,30 +50,30 @@ describe('ExampleViewer', () => { | |||
| component = fixture.componentInstance; | |||
| }); | |||
|
|
|||
| it('should toggle showSource boolean', () => { | |||
| it('should toggle showSource boolean', async(() => { | |||
There was a problem hiding this comment.
Shouldn't we be doing fakeAsync here?
There was a problem hiding this comment.
async should be fine since we don't care about the end of the operation, just that it finishes
jelbourn
pushed a commit
that referenced
this pull request
May 2, 2018
richdev350
added a commit
to richdev350/material.angular.io
that referenced
this pull request
Jun 29, 2022
karkumar089
added a commit
to karkumar089/material.angular.io
that referenced
this pull request
Feb 1, 2023
sailing-dev
added a commit
to sailing-dev/material.angular.io
that referenced
this pull request
Feb 5, 2023
sailingdev
added a commit
to sailingdev/material.angular.io
that referenced
this pull request
Apr 14, 2023
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Nov 6, 2024
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Dec 12, 2024
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Dec 16, 2024
alexeagle
pushed a commit
to alexeagle/material2
that referenced
this pull request
Dec 18, 2024
josephperrott
pushed a commit
to angular/components
that referenced
this pull request
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.