Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 2478f1d

Browse files
fix(layouts): interpolated values, validations, test & CSS fixes
* improved consistent use of `attrs.$observe( )` to watch for interpolated attribute values (for Layout attributes which support value specifiers). * add validation of Layout attribute values with fallbacks to default value approprate to each attribute type * significant code cleanup for use of `$observe( )` * removed possible classname generation with raw, uninterpolated strings * removed multiple classname generation * fixed invalid classname generation when interpolation values are invalid * remove `md-` prefix from layout class names * remove all attribute selectors from layout.scss * deprecated use of `offset` attribute; now uses `layout-offset` * add box-sizing to all flex variants * add max-width/height to flex variants * fixed max-width/height for flex 33, 34, 66, and 67 variants. * complete refactor for spec testing of Layouts Fixes #5076. Fixes #5054. Refs #5014. Fixes #4994. Fixes #4959. Fixes #4902. Fixes #2954. Fixes #5014. Closes #5090.
1 parent b4e6354 commit 2478f1d

File tree

5 files changed

+719
-440
lines changed

5 files changed

+719
-440
lines changed

docs/app/css/layout-demo.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ demo-include {
4242
margin-top: 16px;
4343
}
4444

45-
.layout-demo :not(.md-layout) {
45+
.layout-demo :not(.layout-row),
46+
.layout-demo :not(.layout-column) {
4647
border: 1px solid #eee;
4748
padding: 8px;
4849
}

docs/app/partials/layout-options.tmpl.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@
8080
<demo-file name="index.html">
8181
<div layout="row" layout-wrap class="colorNested-noPad">
8282
<div flex="33">[flex=33]</div>
83-
<div flex="66">[flex=67]</div>
84-
<div flex="66">[flex=67]</div>
83+
<div flex="67">[flex=67]</div>
84+
<div flex="67">[flex=67]</div>
8585
<div flex="33">[flex=33]</div>
8686
</div>
8787
</demo-file>
@@ -98,10 +98,10 @@
9898
<docs-demo demo-title="Responsive Flex & Offset Attributes" class="small-demo">
9999
<demo-file name="index.html">
100100
<div layout="row" class="colorNested">
101-
<div flex="66" flex-sm="33">
101+
<div flex="66" flex-sm="34">
102102
I flex to one-third of the space on mobile, and two-thirds on other devices.
103103
</div>
104-
<div flex="33" flex-sm="66">
104+
<div flex="34" flex-sm="66">
105105
I flex to two-thirds of the space on mobile, and one-third on other devices.
106106
</div>
107107
</div>

0 commit comments

Comments
 (0)