-
Notifications
You must be signed in to change notification settings - Fork 3.4k
layout-margin / layout-padding and flex="?" #5014
Comments
+1 |
probably related: Flex turns into |
+1 |
@tinusn - Here is a CodePen that shows the working v0.11.2 Layout features: http://codepen.io/ThomasBurleson/pen/RWgqom <div ng-app="demoApp" layout="column" layout-fill>
<div layout="row" layout-margin flex>
<div class="one" flex="20"> test1 </div>
<div class="two" flex="80"> test2 </div>
</div>
<div layout="row" layout-padding flex >
<div class="one" flex="20"> test1 </div>
<div class="two" flex="80"> test2 </div>
</div>
</div>
|
* improved consistent use of `attrs.$observe( )` to watch for interpolated attribute values (for Layout attributes which support value specifiers). * add validation of Layout attribute values with fallbacks to default value approprate to each attribute type * significant code cleanup for use of `$observe( )` * removed possible classname generation with raw, uninterpolated strings * removed multiple classname generation * fixed invalid classname generation when interpolation values are invalid * remove `md-` prefix from layout class names * remove all attribute selectors from layout.scss * deprecated use of `offset` attribute; now uses `layout-offset` * add box-sizing to all flex variants * add max-width/height to flex variants * fixed max-width/height for flex 33, 34, 66, and 67 variants. * complete refactor for spec testing of Layouts Fixes #5076. Fixes #5054. Refs #5014. Fixes #4994. Fixes #4959. Fixes #4902. Fixes #2954. Fixes #5014.
* improved consistent use of `attrs.$observe( )` to watch for interpolated attribute values (for Layout attributes which support value specifiers). * add validation of Layout attribute values with fallbacks to default value approprate to each attribute type * significant code cleanup for use of `$observe( )` * removed possible classname generation with raw, uninterpolated strings * removed multiple classname generation * fixed invalid classname generation when interpolation values are invalid * remove `md-` prefix from layout class names * remove all attribute selectors from layout.scss * deprecated use of `offset` attribute; now uses `layout-offset` * add box-sizing to all flex variants * add max-width/height to flex variants * fixed max-width/height for flex 33, 34, 66, and 67 variants. * complete refactor for spec testing of Layouts Fixes #5076. Fixes #5054. Refs #5014. Fixes #4994. Fixes #4959. Fixes #4902. Fixes #2954. Fixes #5014. Closes #5090.
@ThomasBurleson The pen you have made still does not work? Here is what I would expect (or at least, that is how it worked in 0.10.x): But the pen you have made gives this: I fixed the two pens in the beginning, so now the layout row/column works, but layout-padding and layout-margin still does not work. Finally I added a pen that shows that it works with just flex. |
In 0.11.1 it's works. In current version 0.11.2 you need add .flex class manually. <div layout="row" layout-padding>
<div class="flex" flex="20"></div>
<div class="flex" flex="80"></div>
</div> |
In release 0.10.x adding layout-margin and layout-padding to a parent container and then adding flex="?" to a child works as expected, but in 0.11.2 it does not.
Here is a codepen demonstrated the issue:
0.10.1
0.11.2 (not, this one does not work at all... dunno why)
And here is a codepen with just flex, that works in 0.11.2
0.11.2 - flex
The issue seems to be that the new class based approach does not add "flex" to the class list and is thus not hit by the following:
In 0.10.1:
becomes
whereas in 0.11.2 it becomes:
The text was updated successfully, but these errors were encountered: