Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Commit

Permalink
fix(autocomplete): fixes height calculation issue when autocomplete i…
Browse files Browse the repository at this point in the history 
…s near the bottom of the body

fixes #5209. closes #5718.
  • Loading branch information
@ThomasBurleson
Robert Messerle authored and ThomasBurleson committed Nov 23, 2015
1 parent eb94d64 commit a1889cd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/style/structure.scss
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
html, body {
height: 100%;
min-height: 100%;

This comment has been minimized.

Sign in to view

Copy link
@mckenzielong

mckenzielong Nov 23, 2015

Contributor

FYI: this has broken the docs in Chrome 46 / Opera 33. Page is no longer scrollable. Setting height:100% fixes the docs page scrolling.

This comment has been minimized.

Sign in to view

Copy link
@EladBezalel

EladBezalel Nov 24, 2015

Member

also it broke dialog positioning

This comment has been minimized.

Sign in to view

Copy link
@ThomasBurleson

ThomasBurleson Nov 24, 2015

Contributor

@robertmesserle - i think we need to revert this commit (and reopen the associated issues). This has significant side affects.

This comment has been minimized.

Sign in to view

Copy link
@robertmesserle

robertmesserle Nov 24, 2015

Contributor

@ThomasBurleson Agreed.
color: rgba(0,0,0,0.87);
background: white;
position: relative;
Expand Down

0 comments on commit a1889cd

Please sign in to comment.