Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

refactor(css): include Roboto font as part of themes #1009

Closed
robertmesserle opened this issue Dec 19, 2014 · 5 comments
Closed

refactor(css): include Roboto font as part of themes #1009

robertmesserle opened this issue Dec 19, 2014 · 5 comments
Assignees
Milestone

Comments

@robertmesserle
Copy link
Contributor

Right now, we are including the Roboto font from Google through a <link> tag. It occurred to me that we could just as easily include it via @import in our CSS.

This also begged the question: where should this live? Should this be tied into themes?

@robertmesserle robertmesserle added this to the 0.8.0-rc1 milestone Dec 19, 2014
@epelc
Copy link
Contributor

epelc commented Dec 20, 2014

Isn't it already included by the angular-material css?

@ThomasBurleson ThomasBurleson modified the milestones: 0.8.0, 0.9.0 Jan 30, 2015
@marcysutton marcysutton self-assigned this Apr 1, 2015
@marcysutton
Copy link
Contributor

It isn't included, you have to include the <link> tag from Google fonts. We can easily swap it out for an @import in the Typography stylesheet.

@import url(http://fonts.googleapis.com/css?family=Roboto:500,400italic,700,400, 300);

@marcysutton
Copy link
Contributor

Given Roboto is the font for Material Design, I don't think this should be configurable. Adding it to typography.scss and removing the link from our index HTML.

@marcysutton
Copy link
Contributor

Moving to 0.10.0 to hold discussion about best approach for including font. Options include a non-blocking JS utility to load font if not already included.

marcysutton pushed a commit that referenced this issue Apr 13, 2015
Closes #2247, temporary until #1009 is resolved
@ghost
Copy link

ghost commented Apr 22, 2015

Whatever the choice, 'RobotoDraft' is now obsolete and can be removed from the font-families.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants