This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
input: indentation different from the Material Design spec #10105
Labels
- Breaking Change
has: Pull Request
A PR has been created to address this issue
P3: important
Important issues that really should be fixed when possible.
resolution: fixed
type: spec alignment
For issues related to aligning with the Material Design Spec
ui: CSS
Milestone
Comments
@clshortfuse thoughts? |
@rvarbanov as this is true, this is a breaking change means it would only get in in This would be nice to have but not that important right now imo :) |
Splaktar
added
- Easy fix
P4: minor
Minor issues. May not be fixed without community contributions.
ui: CSS
and removed
priority: low
labels
Nov 21, 2017
codymikol
added a commit
to codymikol/material
that referenced
this issue
Aug 19, 2018
remove 2px of padding-left from input boxes as this does not follow the material design spec Fixes angular#10105
3 tasks
Splaktar
added
type: spec alignment
For issues related to aligning with the Material Design Spec
and removed
needs: Pull Request
labels
Aug 29, 2018
Splaktar
changed the title
Input indentation different from the official Material Design page
input: indentation different from the Material Design spec
Aug 29, 2018
Splaktar
added
P3: important
Important issues that really should be fixed when possible.
and removed
P4: minor
Minor issues. May not be fixed without community contributions.
labels
May 28, 2020
3 tasks
Splaktar
added a commit
that referenced
this issue
Jun 29, 2020
Fixes #10105. Closes #11421. BREAKING CHANGE: `md-input` and `md-select` inside of `md-input-container`s have been updated to use indentation that is consistent with the spec (aligned to the left in LTR and the right in RTL). This may cause some minor layout issues in apps that depended upon the previous `2px` padding inside of `md-input-container`.
Splaktar
added a commit
that referenced
this issue
Jun 29, 2020
Fixes #10105. Closes #11421. BREAKING CHANGE: `md-input` and `md-select` inside of `md-input-container`s have been updated to use indentation that is consistent with the spec (aligned to the left in LTR and the right in RTL). This may cause some minor layout issues in apps that depended upon the previous `2px` padding inside of `md-input-container`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
- Breaking Change
has: Pull Request
A PR has been created to address this issue
P3: important
Important issues that really should be fixed when possible.
resolution: fixed
type: spec alignment
For issues related to aligning with the Material Design Spec
ui: CSS
Actual Behavior:
What is the issue? *
Input indentation different from the official Material Design page.What is the expected behavior?
The Angular Material input have padding-left: 2px, but the Material Design page doesn't. If we are following the Material Design there the input label, input text, and input underline should be equally aligned to the left.CodePen (or steps to reproduce the issue): *
CodePen Demo which shows your issue:
https://material.angularjs.org/latest/demo/inputDetails:
Compare both pages https://material.angularjs.org/latest/demo/input and https://material.io/archive/guidelines/components/text-fields.html#text-fields-layout to see the differenceAngular Versions: *
Angular Version:
1.5.9Angular Material Version:
1.1.1Additional Information:
Browser Type: *
Google ChromeBrowser Version: *
Version 55.0.2883.75 (64-bit)OS: *
macOS Sierra, 10.12.1Stack Traces:
n/aShortcut to create a new CodePen Demo.
Note:
*
indicates required information. Without this information, your issue may be auto-closed.The text was updated successfully, but these errors were encountered: