Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

menu: dropdown doesn't inherit dark theme #11199

Closed
rudzikdawid opened this issue Mar 28, 2018 · 0 comments · Fixed by #11230
Closed

menu: dropdown doesn't inherit dark theme #11199

rudzikdawid opened this issue Mar 28, 2018 · 0 comments · Fixed by #11230
Assignees
@Splaktar
Labels
has: Pull Request A PR has been created to address this issue P4: minor Minor issues. May not be fixed without community contributions. resolution: fixed type: bug ui: theme
Milestone
1.1.9

Comments

@rudzikdawid
Copy link
Contributor

rudzikdawid commented Mar 28, 2018 •
edited
Loading

example of issue: https://codepen.io/anon/pen/qoxORQ?editors=1010

using dark theme and md-menu causes render issue: light background.
material2 has proper implementation: dark menu in dark theme, light menu in light theme.
But in material1 we have light background in dark theme;

md-menu has the same problem as md-select #3379 #11198
@rudzikdawid rudzikdawid mentioned this issue Mar 28, 2018
Closed
@Splaktar Splaktar self-assigned this Mar 28, 2018
@Splaktar Splaktar added type: bug ui: theme P4: minor Minor issues. May not be fixed without community contributions. labels Mar 28, 2018
@Splaktar Splaktar added this to the 1.1.9 milestone Mar 28, 2018
@Splaktar Splaktar removed their assignment Mar 30, 2018
rudzikdawid added a commit to rudzikdawid/material that referenced this issue Apr 11, 2018
@rudzikdawid
fix(menu): md-menu panel theme supports dark mode
a113b9d 
Closes angular#11199
@rudzikdawid rudzikdawid mentioned this issue Apr 11, 2018
Merged
3 tasks
@Splaktar Splaktar changed the title md-menu dropdown doesn't inherit dark theme menu: dropdown doesn't inherit dark theme Apr 16, 2018
@Splaktar Splaktar self-assigned this Apr 16, 2018
@Splaktar Splaktar added has: Pull Request A PR has been created to address this issue and removed needs: Pull Request labels Apr 16, 2018
@Splaktar Splaktar mentioned this issue Apr 16, 2018
Closed
rudzikdawid added a commit to rudzikdawid/material that referenced this issue Apr 17, 2018
@rudzikdawid
fix(menu): md-menu panel theme supports dark mode
3128f93 
Closes angular#11199
andrewseguin pushed a commit that referenced this issue Apr 23, 2018
@rudzikdawid @andrewseguin
fix(menu): md-menu panel theme supports dark mode (#11230)
ef14194 
Closes #11199
Splaktar pushed a commit that referenced this issue Jul 31, 2018
@rudzikdawid @Splaktar
fix(menu): md-menu panel theme supports dark mode (#11230)
f4607ae 
Closes #11199
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
has: Pull Request A PR has been created to address this issue P4: minor Minor issues. May not be fixed without community contributions. resolution: fixed type: bug ui: theme
Projects
None yet
Milestone
1.1.9
Development

Successfully merging a pull request may close this issue.

fix(menu): md-menu panel theme supports dark mode rudzikdawid/material
2 participants
@Splaktar @rudzikdawid