Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Upgrade peer dependency to angular 1.7.0 #11281

Closed
enderdickerson opened this issue May 15, 2018 · 7 comments
Closed

Upgrade peer dependency to angular 1.7.0 #11281

enderdickerson opened this issue May 15, 2018 · 7 comments
Assignees
@Splaktar
Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release. resolution: fixed
Milestone
1.1.10

Comments

@enderdickerson
Copy link

Bug, enhancement request, or proposal:

Enhancement request

CodePen and steps to reproduce the issue:

CodePen Demo which demonstrates the issue:

install angular 1.7.0

Detailed Reproduction Steps:

  1. npm install angular@1.7.0

What is the expected behavior?

No warnings from angular material

What is the current behavior?

npm WARN angular-material@1.1.9 requires a peer of angular@>=1.4 <1.7 but none is installed.
etc...

What is the use-case or motivation for changing an existing behavior?

Final 1.x major release from angular is 1.7.x.

Which versions of AngularJS, Material, OS, and browsers are affected?

  • AngularJS: 1.7.0
  • AngularJS Material: 1.1.9
  • OS: Windows 10
  • Browsers: N/A

Is there anything else we should know? Stack Traces, Screenshots, etc.
@Splaktar Splaktar added this to the 1.1.10 milestone May 16, 2018
@Splaktar Splaktar self-assigned this May 16, 2018
@Splaktar Splaktar added needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community hotlist: Angular 1.7 support labels May 16, 2018
@Splaktar
Copy link
Contributor

Splaktar commented May 16, 2018 •
edited
Loading

Thank you for opening this. We were expecting 1.7 to come out in June, so we haven't yet done the proper level of testing for compatibility with AngularJS 1.7. We plan to address this in 1.1.10.

It would be helpful if anyone could report if they see issues in 1.7 (in a separate issue) or if things are working fine for them after the upgrade (fine to do in this issue).

@Splaktar Splaktar added the P1: urgent Urgent issues that should be addressed in the next minor or patch release. label May 16, 2018
@jpike88
Copy link
Contributor

jpike88 commented Jun 4, 2018 •
edited
Loading

Everyone works fine for me, have been using it as soon as it was available.

@Splaktar
Copy link
Contributor

Splaktar commented Jun 8, 2018

I am going to update https://github.com/angular/bower-material today to support AngularJS 1.7.0 in the peerDependencies of NPM.

I am also going to make the latest versions of AngularJS ^1.6.0 the dependencies for JSPM (updated from ^1.5.3) and Bower (updated from ^1.4.8). These can't be ^1.7.0 due to the issue below.

However, we can't support AngularJS 1.7.1 due to #11319. PR #11320 should fix that in AngularJS Material 1.1.10.

Splaktar added a commit to angular/bower-material that referenced this issue Jun 8, 2018
@Splaktar
update(dependencies): add support for AngularJS 1.7.0
237371f 
default to the latest AngularJS 1.6.x in JSPM and Bower

Fixes angular/material#11281
@Splaktar Splaktar mentioned this issue Jun 8, 2018
Merged
Splaktar added a commit to angular/bower-material that referenced this issue Jun 8, 2018
@Splaktar
update(dependencies): add support for AngularJS 1.7.0
f52d569 
default to the latest AngularJS 1.6.x in JSPM and Bower

Fixes angular/material#11281
@Splaktar Splaktar added has: Pull Request A PR has been created to address this issue resolution: fixed and removed needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community labels Jun 8, 2018
@Splaktar
Copy link
Contributor

Splaktar commented Jun 8, 2018

This will be available as part of the releases generated for each PR next week when a PR gets merged. Then it will also be part of AngularJS Material 1.1.10.

@endisway
Copy link

Since this will only ship as part of 1.1.10, the docs at https://github.com/angular/bower-material/#installing-angularjs-material were updated a little too soon and they now state that 1.1.9 supports AngularJS 1.7.0.

@Splaktar
Copy link
Contributor

@endisway 1.1.9 does support AngularJS 1.7.0, but it doesn't support 1.7.1 until 1.1.10.

Using 1.1.9 with AngularJS 1.7.0 will generate a peer dependency warning in NPM, but it's safe to ignore for 1.7.0 (not 1.7.1!).

cedricbonhomme added a commit to monarc-project/ng-client that referenced this issue Jun 20, 2018
@cedricbonhomme
Upgrade AngularJS to 1.7.0. For the moment some problem of dependenci…
076a025 
…es with 1.7.2 (angular/material#11281).
Splaktar added a commit to DevIntent/bower-material that referenced this issue Jun 27, 2018
@Splaktar
update(dependencies): add support for AngularJS 1.7.x
af93207 
- default to the latest AngularJS ^1.7.2 in JSPM and Bower
- AngularJS Material does not support AngularJS 1.7.1

Relates to angular/material#11281
@Splaktar
Copy link
Contributor

Update on this

Splaktar added a commit to angular/bower-material that referenced this issue Jun 27, 2018
@Splaktar
update(npm): explicitly mark AngularJS 1.7.1 as not supported
ebbd171 
Relates to angular/material#11281
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release. resolution: fixed
Projects
None yet
Milestone
1.1.10
Development

No branches or pull requests
4 participants
@enderdickerson @endisway @Splaktar @jpike88