This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(input): remove 2px left padding on inputs #11421
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove 2px of padding-left from input boxes as this does not follow the material design spec Fixes angular#10105
googlebot
added
the
cla: yes
PR author has signed Google's CLA: https://opensource.google.com/docs/cla/
label
Aug 19, 2018
Splaktar
added
needs: review
This PR is waiting on review from the team
ui: CSS
- Breaking Change
P4: minor
Minor issues. May not be fixed without community contributions.
labels
Aug 29, 2018
Splaktar
approved these changes
Aug 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you please add a before and after screenshot? Also a screenshot from the MD spec to compare against would be helpful.
Thank you!
Splaktar
added
pr: lgtm
This PR has been approved by the reviewer
type: spec alignment
For issues related to aligning with the Material Design Spec
and removed
needs: review
This PR is waiting on review from the team
labels
Aug 29, 2018
@Splaktar Added screenshots to the PR for documentation |
Splaktar
added
P3: important
Important issues that really should be fixed when possible.
and removed
P4: minor
Minor issues. May not be fixed without community contributions.
labels
May 28, 2020
3 tasks
I found some addition cases that this does not cover with both |
Splaktar
added a commit
that referenced
this pull request
Jun 29, 2020
Fixes #10105. Closes #11421. BREAKING CHANGE: `md-input` and `md-select` inside of `md-input-container`s have been updated to use indentation that is consistent with the spec (aligned to the left in LTR and the right in RTL). This may cause some minor layout issues in apps that depended upon the previous `2px` padding inside of `md-input-container`.
Splaktar
added a commit
that referenced
this pull request
Jun 29, 2020
Fixes #10105. Closes #11421. BREAKING CHANGE: `md-input` and `md-select` inside of `md-input-container`s have been updated to use indentation that is consistent with the spec (aligned to the left in LTR and the right in RTL). This may cause some minor layout issues in apps that depended upon the previous `2px` padding inside of `md-input-container`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
- Breaking Change
cla: yes
PR author has signed Google's CLA: https://opensource.google.com/docs/cla/
P3: important
Important issues that really should be fixed when possible.
type: spec alignment
For issues related to aligning with the Material Design Spec
ui: CSS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove 2px of padding-left from input boxes as this does not follow the material design spec
Fixes #10105
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently input boxes have 2px of padding-left. The material design spec has no left padding.
According to the original material design spec only top and bottom padding should exist on input fields.
Issue Number: #10105
What is the new behavior?
The 2px of left padding have been removed.
Does this PR introduce a breaking change?
This will change the styling of input components, although a minor change, anyone who has styled specifically around this may need to make minor changes to their own styles.
Other information
It does not seem that autocomplete or datepicker have this extra padding and they don't seem to be using the modified class. It seems that the only affected component will be input and all the other components are following the spec.