Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

calendar: demo broken, showing 1880 dates, while model is correct #11919

Closed
Splaktar opened this issue May 27, 2020 · 2 comments · Fixed by #11939
Closed

calendar: demo broken, showing 1880 dates, while model is correct #11919

Splaktar opened this issue May 27, 2020 · 2 comments · Fixed by #11939
Assignees
Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release. severity: regression This issue is related to a regression type: bug
Milestone

Comments

@Splaktar
Copy link
Contributor

Bug

Demo and steps to reproduce the issue

This blank StackBlitz demo can be used to create a reproduction that demonstrates your issue.

Demo URL (required)*: https://material.angularjs.org/HEAD/demo/datepicker

Detailed Reproduction Steps

  1. Just load the page of the datepicker demos
  2. Look at the calendar

Explain the expected behavior

It should show the start date as today and the end date as 5 days from today. The model values are correct.

Explain the current behavior

The start date appears to be Jan 1880 and the end date appears to be sometime in May 1880. The model values appear to be correct. But the calendar hasn't scrolled to the right month/year.

Discuss the use-case or motivation for changing the existing behavior

Basic functionality.

List the affected versions of AngularJS, Material, OS, and browsers

  • AngularJS: 1.1.23-master
  • AngularJS Material: 1.7.9
  • OS: macOS Catalina
  • Browsers: Chrome 83

Add anything else we should know

Screenshots

Screen Shot 2020-05-27 at 03 38 28

@Splaktar Splaktar added type: bug needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community severity: regression This issue is related to a regression P1: urgent Urgent issues that should be addressed in the next minor or patch release. labels May 27, 2020
@Splaktar Splaktar added this to the 1.1.23 milestone May 27, 2020
@Splaktar Splaktar self-assigned this May 27, 2020
@Splaktar Splaktar changed the title calendar: demo broken, showing 1880 dates calendar: demo broken, showing 1880 dates, while model is correct May 27, 2020
@Splaktar
Copy link
Contributor Author

Splaktar commented Jun 15, 2020

The commit that caused this was 2a01746 from PR #11906.

@Splaktar
Copy link
Contributor Author

It turns out that this comment was inaccurate. #8585 was found to not be a real issue and was closed w/o any changes. So this is still needed for md-calendar and needs to be marked as part of the design and no longer a workaround of a md-virtual-repeat-container bug.

@Splaktar Splaktar added has: Pull Request A PR has been created to address this issue and removed needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community labels Jun 16, 2020
Splaktar added a commit that referenced this issue Jun 16, 2020
- #8585 turned out to not be a bug
- this restored code is not actually a workaround for a bug
  - but actually part of the implementation needed for `md-calendar`
- improve some types and JSDoc

Fixes #11919
Splaktar added a commit that referenced this issue Jun 17, 2020
- #8585 turned out to not be a bug
- this restored code is not actually a workaround for a bug
  - but actually part of the implementation needed for `md-calendar`
- improve some types and JSDoc

Fixes #11919
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release. severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant