Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

mdCheckbox: focus should show ink circle #1336

Closed
marcysutton opened this issue Jan 29, 2015 · 1 comment
Closed

mdCheckbox: focus should show ink circle #1336

marcysutton opened this issue Jan 29, 2015 · 1 comment
Assignees
Labels
a11y This issue is related to accessibility
Milestone

Comments

@marcysutton
Copy link
Contributor

mdCheckbox has a temporary focus style where a dotted border is shown around the textContent. To follow the Material Design spec more closely, the checkbox should show an ink circle on focus that persists until the element is blurred:

Checkbox designs

This will make checkboxes labeled with only the aria-label and no textContent show focus. An example requiring this is the list item control by @rschmukler (#985, currently in progress):

<md-list>
    <md-list-item>
        <p>Subscribe</p>
        <md-checkbox aria-label="Subscribe"></md-checkbox>
    </md-list-item>
</md-list>
@marcysutton marcysutton added the a11y This issue is related to accessibility label Jan 29, 2015
@marcysutton marcysutton self-assigned this Feb 3, 2015
@marcysutton marcysutton added this to the 0.9.0 milestone Feb 3, 2015
@marcysutton
Copy link
Contributor Author

Question submitted around whether focus styles should persist when clicking with the mouse or trackpad, since the browser is actually focusing the control. Keyboard styles are definitely still needed (but they are already a WIP).

@marcysutton marcysutton changed the title mdCheckbox: focus should show persistent ripple mdCheckbox: focus should show ink circle Mar 31, 2015
marcysutton pushed a commit that referenced this issue Apr 10, 2015
No focus on click

Closes #1336
marcysutton pushed a commit that referenced this issue Apr 11, 2015
Updates button, checkbox and radio to only show focus on keyboard interaction using the .md-focused class

Closes #1336
@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Apr 11, 2015
marcysutton pushed a commit that referenced this issue Apr 11, 2015
Updates button, checkbox and radio to only show focus on keyboard interaction using the .md-focused class

Closes #1336
@marcysutton marcysutton removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Apr 13, 2015
marcysutton pushed a commit that referenced this issue Apr 13, 2015
Updates button, checkbox and radio to only show focus on keyboard interaction using the .md-focused class

Closes #1336
marcysutton pushed a commit that referenced this issue Apr 13, 2015
Updates button, checkbox and radio to only show focus on keyboard interaction using the .md-focused class

Closes #1336
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants