-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(slider): adds padding inside of slider to fit the thumb #1391
Conversation
24b9ef5
to
2662c04
Compare
@ThomasBurleson Please note that this will cause styles to change for some users. Basically, in order for this to work, I had to add padding inside the actual slider wrapper, which causes the slider to shrink. If this is not how we expect it to work, then comment here and we can discuss alternative solutions. |
function() { return isDisabledParsed(scope.$parent); } : | ||
angular.noop; | ||
var wrapper = angular.element(element[0].querySelector('.md-slider-wrapper')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you creating a unused wrapper
variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question - I used it at one point while fixing this, but apparently, didn't end up needing it. Will remove.
@robertmesserle - This effectively creates a left/right 24px padding around md-slider so the thumb shows properly at the start/end ranges.
|
223dec7
to
a22e6aa
Compare
@ThomasBurleson The 24px padding is the size needed for the focus/held state. |
a22e6aa
to
8093c30
Compare
@robertmesserle This is not the right fix. size of slider became smaller because of padding. |
8093c30
to
5dbcaa6
Compare
@sunnyshah01 @ThomasBurleson Updated this PR to include a safer method that should not impact the size at all. |
4da082a
to
d7a7e48
Compare
@robertmesserle - |
d817edb
to
18d47c4
Compare
Closes #1343