Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

ng-click no longer working at all across my mobile app #1640

Closed
jeffthompson1971 opened this issue Feb 24, 2015 · 16 comments
Closed

ng-click no longer working at all across my mobile app #1640

jeffthompson1971 opened this issue Feb 24, 2015 · 16 comments

Comments

@jeffthompson1971
Copy link

Just moved to the latest-greatest material, and now my whole app is broken. ng-click is never fired for any of my controls on any of my webviews. FYI I'm building an appgyver supersonic app. I've been using ng-click with angular-material for the past 6 months with no issues at all. But now it's broken with 100% consistency.

Is this a know issue? should I be using some other events other than ng-click in my angular app?

@gustavohenke
Copy link

I've been using v0.8.0-rc1 for a week, and have no issues.
You should probably post a plunkr/codepen/<insert snippet site here> so guys can help you debug the problem.

@jeffthompson1971
Copy link
Author

my app is a bit to large/complicated to try to put a code-pen together.. needs to be run in a simulator or real device. not sure of any way to share it easily.

So you are also using appgyver/supersonic with angular-material for the UI? If so are you just using ng-click ?

I just did do this though.. i'm in the process of building a web-page that re-uses most of my angular services etc. that I use on my mobile app. And I also just pulled in latest/greatest angular-material. basically i just started with the angular-material-seed app. that app has a button that opens the left drawer. It works fine on my desktop browser, but from my android device in chrome, the touch fails. pressing that button does nothing. I"m assuming this is the same issue?

if you have a mobile device, can you try to open this link in your browser and see if pressing the button in the upper right corner works?


I see this issue also:
#1403

if you read it seems maybe general touch issue as well perhaps? hmmmm the plot thickens ... :)

@gustavohenke
Copy link

Hmmm, I spoke too soon.
In my own app, I activated the touch emulation in Chrome DevTools and found that some clicks are never fired.

The following issues may be related to this one: #1406, #1528

And no, I don't use Appgyver, I'm using plain Cordova,

@gustavohenke
Copy link

In my case, I just found that I depended upon ngTouch module, which conflicted with ngMaterial.
For now, my clicks are working back again.

@jeffthompson1971
Copy link
Author

are you saying I need to use ngTouch? I just verified that going back to the older version of material works fine so clearly this is new breakage across the board. I was reading about their removing hammer so guessing that's the breakage.

when can we expect a fix? is ngTouch a work-around or a proper dependency?

UPDATE - I tried to pull in ng-touch, but still not getting any events, at least via ng-click.

@marcysutton
Copy link
Contributor

$mdGestures is still causing problems. This is indeed a related issue: #1406

@gustavohenke
Copy link

are you saying I need to use ngTouch?

No, with ngTouch I had problems. Without it = all green.

@jeffthompson1971
Copy link
Author

Not for me. Is there a fix on the way?

Also gustavo - what is your tech stack? are you saying this is working for you on a mobile device or just web browser? for me... if i pull in ngTouch then I can get the swipe working fine, but click never fires so it's useless.

@jeffthompson1971
Copy link
Author

I really need to know if the angular-material team recognizes the breakage from 7 to 8 is indeed there and if there is a fix planned. If the answer is 'go away we don't care about your issue' that's valid, I'd just like to know so I can move onto another UI solution.

I just did a final test to make it quite clear there is breakage on ng-click...

Starting from my broken build that pulls in the latest v8 angular-material what i did was:

  1. git checkout 69462fe // commit id for one of the v7 builds
  2. gulp build
  3. reload my app

and everything is perfect again. i know that hammer was pulled out etc. so clearly there was code churn around touch events right? clearly there is an issue and my question is if it will be addressed or not. I can move on I just need to know what the plan is. appreciate a quick comment letting me know the status...

@ThomasBurleson
Copy link
Contributor

@jeffthompson1971 - we definitely care about this issue. Improving $mdGestures is a priority for us. Please expect some fixes/traction on this in the near future.

@Trimud
Copy link

Trimud commented Mar 5, 2015

Hello,

I'm also having this issue using ngmaterial with Ionic framework.
Adding data-tap-disabled="true" fixes the issue on some places but breaks other things like page scrolling.
Thank you for adding it to the next milestone. I'll be waiting impatiently.

@jeffthompson1971
Copy link
Author

thanks! ... I'm gonna hold out then. .for now I'm just using v7 for my
mobile app and latest/greatest works fine for my web site (web app).
Look forward to the fix so I can reference one library across my stuff :)

On Tue, Mar 3, 2015 at 10:05 PM, Thomas Burleson notifications@github.com
wrote:

@jeffthompson1971 https://github.com/jeffthompson1971 - we definitely
care about this issue. Improving $mdGestures is a priority for us. Please
expect some fixes/traction on this in the near future.


Reply to this email directly or view it on GitHub
#1640 (comment).

@rlucian
Copy link

rlucian commented Mar 17, 2015

If this was working in 0.7.0 (so far I can confirm too) , could we see a fix in the current git code so we can use it (with the related risks) from rawgit.com?

@robertmesserle robertmesserle modified the milestones: 0.10.0, 0.9.0 Mar 19, 2015
@yarl
Copy link
Contributor

yarl commented Mar 23, 2015

+1 for @rlucian's statement, definitely some fix for now will be really handy.

@rlucian
Copy link

rlucian commented Mar 25, 2015

unfortunately it appears this has been moved to milestone 0.10.0, probably because there's no easy fix, so it might not get fixed too soon.

@robertmesserle robertmesserle modified the milestones: Backlog, 0.10.0 Jun 10, 2015
@robertmesserle robertmesserle modified the milestones: 1.0-beta1, Backlog Aug 4, 2015
@naomiblack
Copy link
Contributor

We have made a number of improvements to gestures as of 0.10.1.
If there are specific issues (excluding Ionic, which we already track in another bug #2758) please file a new issue with a codepen repro case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants