Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

bug(tabs): disconnect causing issues #1698

Closed
robertmesserle opened this issue Feb 26, 2015 · 1 comment
Closed

bug(tabs): disconnect causing issues #1698

robertmesserle opened this issue Feb 26, 2015 · 1 comment
Assignees
@robertmesserle
Labels
type: bug
Milestone
0.9.0

Comments

@robertmesserle
Copy link
Contributor

As posted by @mxdubois:

This causes a problem for me where the scope is disconnected after it is reconnected by onSelect during the initial load. The bug results in ng-model bindings in the initially selected tab not working until the user switches to another tab and switches back.

In what case is the $timeout necessary? If we need to keep the $timeout, we should save the promise returned by $timeout and cancel it in onSelect where we call reconnectScope. If that sounds good, I can submit a PR.

Link: 78ba497#commitcomment-9946067
@robertmesserle robertmesserle added this to the 0.9.0 milestone Feb 26, 2015
@robertmesserle robertmesserle self-assigned this Feb 26, 2015
@jamie-pate
Copy link

I noticed that on('$destroy') is no longer called also? (maybe?) wouldn't this be a potential leak?

robertmesserle added a commit that referenced this issue Mar 17, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
684fada 
Closes #1850
Closes #1698
Closes #1570
Closes #1564
Closes #1518
Closes #1516
Closes #1506
Closes #1505
Closes #1403
Closes #1387
Closes #1380
Closes #1261
Closes #1247
Closes #1140
@robertmesserle robertmesserle mentioned this issue Mar 17, 2015
Closed
@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Mar 17, 2015
robertmesserle added a commit that referenced this issue Mar 18, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
a9a20bb 
Closes #1850
Closes #1698
Closes #1570
Closes #1564
Closes #1518
Closes #1516
Closes #1506
Closes #1505
Closes #1403
Closes #1387
Closes #1380
Closes #1261
Closes #1247
Closes #1140
robertmesserle added a commit that referenced this issue Mar 19, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
1b005ff 
Closes #1850
Closes #1698
Closes #1570
Closes #1564
Closes #1518
Closes #1516
Closes #1506
Closes #1505
Closes #1403
Closes #1387
Closes #1380
Closes #1261
Closes #1247
Closes #1140
Closes #1626
robertmesserle added a commit that referenced this issue Mar 19, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
8f07d97 
Closes #1087
Closes #1107
Closes #1140
Closes #1247
Closes #1261
Closes #1380
Closes #1387
Closes #1403
Closes #1443
Closes #1505
Closes #1506
Closes #1516
Closes #1518
Closes #1564
Closes #1570
Closes #1626
Closes #1698
Closes #1850
robertmesserle added a commit that referenced this issue Mar 19, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
ad06889 
Closes #1087
Closes #1107
Closes #1140
Closes #1247
Closes #1261
Closes #1380
Closes #1387
Closes #1403
Closes #1443
Closes #1505
Closes #1506
Closes #1516
Closes #1518
Closes #1564
Closes #1570
Closes #1626
Closes #1698
Closes #1777
Closes #1850
robertmesserle added a commit that referenced this issue Mar 19, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
82f8f64 
Closes #1087
Closes #1107
Closes #1140
Closes #1247
Closes #1261
Closes #1380
Closes #1387
Closes #1403
Closes #1443
Closes #1505
Closes #1506
Closes #1516
Closes #1518
Closes #1564
Closes #1570
Closes #1620
Closes #1626
Closes #1698
Closes #1777
Closes #1850
robertmesserle added a commit that referenced this issue Mar 19, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
4e3ae7f 
Closes #1087
Closes #1107
Closes #1140
Closes #1247
Closes #1261
Closes #1380
Closes #1387
Closes #1403
Closes #1443
Closes #1505
Closes #1506
Closes #1516
Closes #1518
Closes #1564
Closes #1570
Closes #1620
Closes #1626
Closes #1698
Closes #1777
Closes #1850
robertmesserle added a commit that referenced this issue Mar 20, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
1e28e13 
Closes #1087
Closes #1107
Closes #1140
Closes #1247
Closes #1261
Closes #1380
Closes #1387
Closes #1403
Closes #1443
Closes #1505
Closes #1506
Closes #1516
Closes #1518
Closes #1564
Closes #1570
Closes #1620
Closes #1626
Closes #1698
Closes #1777
Closes #1788
Closes #1850
Closes #1959
robertmesserle added a commit that referenced this issue Mar 20, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
865d856 
Closes #1087
Closes #1107
Closes #1140
Closes #1247
Closes #1261
Closes #1380
Closes #1387
Closes #1403
Closes #1443
Closes #1505
Closes #1506
Closes #1516
Closes #1518
Closes #1564
Closes #1570
Closes #1620
Closes #1626
Closes #1698
Closes #1777
Closes #1788
Closes #1850
Closes #1959
Closes #1986
robertmesserle added a commit that referenced this issue Mar 24, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
1337f62 
BREAKING CHANGE: Generated HTML structure has changed, so custom styles
will need to be updated to match the new HTML structure.

Closes #1087
Closes #1107
Closes #1140
Closes #1247
Closes #1261
Closes #1380
Closes #1387
Closes #1403
Closes #1443
Closes #1505
Closes #1506
Closes #1516
Closes #1518
Closes #1564
Closes #1570
Closes #1620
Closes #1626
Closes #1698
Closes #1777
Closes #1788
Closes #1850
Closes #1959
Closes #1986
robertmesserle added a commit that referenced this issue Mar 24, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
99224b3 
BREAKING CHANGE: Generated HTML structure has changed, so custom styles
will need to be updated to match the new HTML structure.

Closes #1087
Closes #1107
Closes #1140
Closes #1247
Closes #1261
Closes #1380
Closes #1387
Closes #1403
Closes #1443
Closes #1505
Closes #1506
Closes #1516
Closes #1518
Closes #1564
Closes #1570
Closes #1620
Closes #1626
Closes #1698
Closes #1777
Closes #1788
Closes #1850
Closes #1959
Closes #1986
robertmesserle added a commit that referenced this issue Mar 25, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
06e27bb 
BREAKING CHANGE: Generated HTML structure has changed, so custom styles
will need to be updated to match the new HTML structure.

Closes #1087
Closes #1107
Closes #1140
Closes #1247
Closes #1261
Closes #1380
Closes #1387
Closes #1403
Closes #1443
Closes #1505
Closes #1506
Closes #1516
Closes #1518
Closes #1564
Closes #1570
Closes #1620
Closes #1626
Closes #1698
Closes #1777
Closes #1788
Closes #1850
Closes #1959
Closes #1986
robertmesserle added a commit that referenced this issue Mar 25, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
12a4ba9 
BREAKING CHANGE: Generated HTML structure has changed, so custom styles
will need to be updated to match the new HTML structure.

Closes #1087
Closes #1107
Closes #1140
Closes #1247
Closes #1261
Closes #1380
Closes #1387
Closes #1403
Closes #1443
Closes #1505
Closes #1506
Closes #1516
Closes #1518
Closes #1564
Closes #1570
Closes #1620
Closes #1626
Closes #1698
Closes #1777
Closes #1788
Closes #1850
Closes #1959
Closes #1986
Closes #2020
robertmesserle added a commit that referenced this issue Mar 26, 2015
@robertmesserle
feat(tabs): refactors tabs to function closer to spec
d3c7dce 
BREAKING CHANGE: Generated HTML structure has changed, so custom styles
will need to be updated to match the new HTML structure.

Closes #1087
Closes #1107
Closes #1140
Closes #1247
Closes #1261
Closes #1380
Closes #1387
Closes #1403
Closes #1443
Closes #1505
Closes #1506
Closes #1516
Closes #1518
Closes #1564
Closes #1570
Closes #1620
Closes #1626
Closes #1698
Closes #1777
Closes #1788
Closes #1850
Closes #1959
Closes #1986
Closes #2020
@ajoslin ajoslin removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs resolution: fixed labels Mar 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@robertmesserle robertmesserle

Labels
type: bug
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

feat(tabs): refactors tabs to function closer to spec angular/material
3 participants
@robertmesserle @jamie-pate @ajoslin