Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Material Accordion #1861

Closed
ask007learning opened this issue Mar 10, 2015 · 40 comments
Closed

Material Accordion #1861

ask007learning opened this issue Mar 10, 2015 · 40 comments
Assignees
Labels
needs: UX team review resolution: won't fix There are no resources to fix this issue, the priority is too low, or it doesn't align w/ MD spec. type: enhancement
Milestone

Comments

@ask007learning
Copy link

How about adding accordion feature to Angularjs material. See example

screen shot 2015-03-25 at 3 16 52 pm

http://codepen.io/LukaszWatroba/pen/pvEOBZ

@tapas4java
Copy link

+1

@ThomasBurleson
Copy link
Contributor

@ask007java - This is very nicely done. We are working on enhancements to md-list with 'expando' features.
@rschmukler - I think we should review @ask007java's solution(s) to make sure we accommodate all features and perf tricks.

@marcysutton
Copy link
Contributor

It also needs a few accessibility things, although it is in really good shape already! Given that accordions are not part of the Material Design spec, should this be deprioritized to happen after our current estimated feature set? (Note: list control is different than accordion)

@mobelio
Copy link

mobelio commented Mar 12, 2015

+1

4 similar comments
@brownish
Copy link

+1

@hiennguyenle
Copy link

+1

@danawhite
Copy link

+1

@kai23
Copy link

kai23 commented Mar 17, 2015

+1

@lee-40square
Copy link

+1

It's such a fundamental feature in most web-apps, particularly using sidebar menus. Looking desperately forward to this. What's the timeline look like with 'expando'?

Actually, looks like #985 would deal with this issue.

@emmagamma
Copy link

👍

@alanpurple
Copy link

+1

1 similar comment
@mbukosky
Copy link

+1

@rschmukler rschmukler modified the milestones: 0.10.0, 0.9.0 Mar 23, 2015
@rschmukler rschmukler added the needs: team discussion This issue requires a decision from the team before moving forward. label Mar 25, 2015
@robertmesserle robertmesserle removed the needs: team discussion This issue requires a decision from the team before moving forward. label Mar 25, 2015
@ThomasBurleson
Copy link
Contributor

@lee-40square - The list expando feature is for nested items; while the accordion feature is for collapsed items.

@miguelchico
Copy link

+1

2 similar comments
@marlonmleite
Copy link

+1

@anyong
Copy link

anyong commented Apr 8, 2015

+1

@sachin-bs
Copy link

I actually like the left side nav accordion style that you are using on your own Material website. Exposing that would not be as difficult since you are already using it yourself! :-)

@robob4him
Copy link

Question: If "Material Design" is all about modeling design after physical materials how does this spec fit? I agree that accordions are used everywhere (and have their use) but I hesitate to put them into an angular-material repository if they aren't part of the spec. I would be more inclined to put them into a non-spec repo specifically for these things.

Not to rain gloom on everyone's parade. Cheers!

@anyong
Copy link

anyong commented Apr 13, 2015

Well surely the accordion folder or cabinet (think big drawer of legal
documents) is a good analogy. You flip through based on the labels and see
the contents by opening it up. Not perfect, but there is certainly a
parallel between the accordion folder and accordion navigation... not part
of the spec, sure, but I agree with above comment that the one used on the
angular material website nav is pretty ideal for a lot of use cases
(especially for nav), and no reason not to include it or at least repackage
it as a standalone component.
On Apr 13, 2015 10:09 PM, "robob4him" notifications@github.com wrote:

Question: If "Material Design" is all about modeling design after physical
materials how does this spec fit? I agree that accordions are used
everywhere (and have their use) but I hesitate to put them into an
angular-material repository if they aren't part of the spec. I would be
more inclined to put them into a non-spec repo specifically for these
things.

Not to rain gloom on everyone's parade. Cheers!

Reply to this email directly or view it on GitHub
#1861 (comment).

@robob4him
Copy link

@anyong I'm not lost on the analogy of the accordion, I'm lost on it's purpose in material design. I'm entirely on point with @sachinny21 but this request is for content accordions, yes? A list view that can expand for content just sounds like a problem directly suited for navigational elements. (eg http://www.google.com/design/spec/layout/structure.html#structure-side-nav). Accordions in material design just don't seem to fit anywhere in the spec. Can someone point me to a section in the spec that gives this idea room to live?

@rosscdh
Copy link

rosscdh commented May 19, 2015

+1

4 similar comments
@cleever
Copy link

cleever commented May 19, 2015

+1

@beebase
Copy link

beebase commented May 19, 2015

+1

@msaliot
Copy link

msaliot commented May 20, 2015

+1

@29x10
Copy link

29x10 commented May 27, 2015

+1

@milad-kh
Copy link

this would be a very useful component

@piotrjaw
Copy link

It can be easily worked around with something like:

<md-item ng-click="showChildren = !showChildren">
    <md-item ng-show="showChildren">I toggle!</md-item>
<md-item>

It also works inside ng-repeat, and it only allows multiple selections open. Single selection variant could be achieved with a controller.

@kranthitech
Copy link

+1

@plotrjaw - I don't see md-item in the list of directives in the documentation here - https://material.angularjs.org/latest/#/api/material.components.list/directive/mdListItem . Are there directives which are not documented yet? - Thanks.

@piotrjaw
Copy link

@kranthitech I'd guess it's a replacement for a div - I got it from one of @marcysutton codepen examples: http://codepen.io/marcysutton/pen/azpmpY.

@ThomasBurleson
Copy link
Contributor

We are currently hyper-focused on a summer release for Angular Material v1.0; which will include Menu and DateTimePicker components, performance enhancements, bug fixes, and improved documentation.

The Expando and Accordion features are definitely on our roadmap but not critical to a v1.0 Beta candidate. Time-permitting, a demo of this feature will be posted on CodePen.

We are locking this issue for now... it will remain an open issue, but locked to future discussions. Please future discussions in the Angular Material Forum

@angular angular locked and limited conversation to collaborators Jun 4, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-beta1, post-1.0 Aug 10, 2015
@ThomasBurleson ThomasBurleson modified the milestones: post-1.0 , Backlog Jan 5, 2016
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, Features Apr 21, 2016
@ThomasBurleson ThomasBurleson modified the milestones: - Features, Deprecated May 26, 2016
@ThomasBurleson
Copy link
Contributor

This issue is closed as part of our ‘Surge Focus on Material 2' efforts.
For details, see our forum posting @ http://bit.ly/1UhZyWs.

@Splaktar Splaktar added the resolution: won't fix There are no resources to fix this issue, the priority is too low, or it doesn't align w/ MD spec. label Dec 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: UX team review resolution: won't fix There are no resources to fix this issue, the priority is too low, or it doesn't align w/ MD spec. type: enhancement
Projects
None yet
Development

No branches or pull requests