Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

demo(tabs): on iOS clicking a static tab causes a loop that crashes Safari #220

Closed
naomiblack opened this issue Aug 28, 2014 · 6 comments
Closed

Comments

@naomiblack
Copy link
Contributor

  1. On iOS (I used an iPad3), open https://material.angularjs.org/#/material.components.tabs/readme/overview
  2. Click one of the tabs in the Static Tabs demo
  3. Observe a loop between showing tabs and showing the code
  4. Notice that after awhile, Safari crashes.

navigator.userAgent: Mozilla/5.0 (iPad; CPU OS 6_1_3 like Mac OS X) ApplewebKit/536.26(KHTML, like Gecko) Version/6.0 Mobile/10B329 Safari/8536.25

@ThomasBurleson ThomasBurleson added this to the 0.0.3 milestone Aug 28, 2014
@ThomasBurleson ThomasBurleson self-assigned this Aug 28, 2014
@ThomasBurleson
Copy link
Contributor

May be easily resolved with CSS-version inkRipple. I will investigate.

@ajoslin
Copy link
Contributor

ajoslin commented Aug 30, 2014

This is really interesting.

When viewing the tabs demo alone (http://material.angularjs.org/generated/material.components.tabs/demo/demo2/) on my iPad, it works fine.

When viewing it within the iFrame on the demo page (https://material.angularjs.org/#/material.components.tabs/readme/overview) it constantly switches between paging and not.

Needs more research and debugging. iFrame problem?

@ThomasBurleson
Copy link
Contributor

I think I see the problem; with possible logic re-looping within tabs.js setPage().
I am investigating today.

@marcysutton
Copy link
Contributor

I'm seeing an automatic loop in the tabs demo on iPhone 5 / iOS 7 as well. It doesn't crash, but it seems to be animating all on its own.
material-tabs-ios-loop

@ThomasBurleson
Copy link
Contributor

This issue has not been resolved.

  • When the demo is viewed directly, the pagination works as expected.
  • When the demo is hosted in an iFrame, the pagination/selection starts looping.

@ajoslin
Copy link
Contributor

ajoslin commented Sep 11, 2014

Fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants