Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-dialog-content: Requires layout="column" for padding to work #2637

Closed
epelc opened this issue Apr 30, 2015 · 1 comment
Closed

md-dialog-content: Requires layout="column" for padding to work #2637

epelc opened this issue Apr 30, 2015 · 1 comment
Assignees
Milestone

Comments

@epelc
Copy link
Contributor

epelc commented Apr 30, 2015

In 0.9.0-rc3 md-dialog-content requires either layout="row" or layout="column" for the padding to work. But I can't really see why you would use row unless you didn't have a title.

Example
image
Markup

<md-dialog>
    <form ng-submit="create()">
    <!-- layout="column" is required or the padding doesn't work -->
        <md-dialog-content layout="column">
            <h3>Create a team</h3>
            <md-input-container>
                <label>Team Name</label>
                <input ng-model="newTeam.Name" type="text" required>
            </md-input-container>
        </md-dialog-content>
        <div class="md-actions">
            <md-button ng-click="cancel()" type="button">Cancel</md-button>
            <md-button type="submit" class="md-primary">Create</md-button>
        </div>
    </form>
</md-dialog>

I think it should either default to layout="column" or fix the padding somehow.

@marcysutton marcysutton added this to the 0.10.0 milestone Apr 30, 2015
@marcysutton marcysutton self-assigned this Apr 30, 2015
@epelc
Copy link
Contributor Author

epelc commented May 1, 2015

@marcysutton I just figured out this only happens if you wrap md-dialog-content. It works fine if you don't but I need to use the outer form for several dialogs. Other people also mentioned they use this layout.

Note using the layout="column" workaround when you have an element between md-dialog and md-dialog-content also breaks the scrolling(as in removes it. You end up only seeing the content near the bottom of md-dialog-content. Also the title becomes hidden.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants