Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Add separate content element for material-card #265

Closed
Frank3K opened this issue Sep 12, 2014 · 6 comments
Closed

Add separate content element for material-card #265

Frank3K opened this issue Sep 12, 2014 · 6 comments

Comments

@Frank3K
Copy link
Contributor

Frank3K commented Sep 12, 2014

In the current build (d5d7e8d) there is a white margin around the image in a material-card. This margin is not conform the design spec.

Previously, this white margin was not present; it is a result of the changes in f33185f.

See also #247.

@ajoslin
Copy link
Contributor

ajoslin commented Sep 16, 2014

OK, to fix this we'll have to add a separate content element for the card itself.

@ajoslin ajoslin changed the title Material-card has margin around image Add separate content element for material-card Oct 2, 2014
@ajoslin
Copy link
Contributor

ajoslin commented Oct 2, 2014

Will fix default padding inside all cards seems too small (not entirely certain) in #347.

@ajoslin ajoslin added this to the 0.4 milestone Oct 2, 2014
@ajoslin ajoslin self-assigned this Oct 2, 2014
@ThomasBurleson ThomasBurleson modified the milestones: 0.5, 0.4 Oct 8, 2014
@ThomasBurleson ThomasBurleson modified the milestones: 0.5, 0.7.0-rc1 Dec 8, 2014
@mzbyszynski
Copy link
Contributor

👍

@ajoslin ajoslin closed this as completed in 28a4f8f Jan 6, 2015
@mzbyszynski
Copy link
Contributor

HI @ajoslin, Not sure if you saw these comments, but I wanted to make sure you are aware that this last commit removed the outer margin and hence paper effect from md-card, which I don't think was your intent. Here's a plunkr that shows the problem. Should be an easy enough fix...

@ajoslin
Copy link
Contributor

ajoslin commented Jan 8, 2015

Ah, right. I'll put it back.

@Frank3K
Copy link
Contributor Author

Frank3K commented Jan 13, 2015

The fix unfortunately re-introduced an old probleem, see #247.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants