Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-toolbar has a delay when used with ng-hide or ng-if #2663

Closed
jelbourn opened this issue May 1, 2015 · 4 comments
Closed

md-toolbar has a delay when used with ng-hide or ng-if #2663

jelbourn opened this issue May 1, 2015 · 4 comments
Assignees
Labels
for: internal contributor The team will address this issue and community PRs are not requested. type: bug
Milestone

Comments

@jelbourn
Copy link
Member

jelbourn commented May 1, 2015

See http://jsbin.com/kixicas/1/edit

Removing the transition CSS property on md-toolbar fixes this, but it is not clear why a transition specifically targeting box-shadow would impact this.

@jelbourn jelbourn added type: bug for: internal contributor The team will address this issue and community PRs are not requested. labels May 1, 2015
@ThomasBurleson
Copy link
Contributor

I think @robertmesserle recently added this shadow transition... not sure why it impacts performance.

@calebegg
Copy link
Member

calebegg commented May 1, 2015

I was actually just debugging a similar problem in our app, and I think the best solution is either to only use transitions that you want ngAnimate to care about (and then only use them in the special classes ng-animate makes) or to use a prefix for ngAnimate:

https://docs.angularjs.org/api/ngAnimate#preventing-collisions-with-third-party-libraries

Though I don't know if it's possible to do that without enforcing it for all angular-material users as well.

@robertmesserle
Copy link
Contributor

I well add a fix for this later. I've had to fix this on other components.
On Fri, May 1, 2015 at 3:29 PM Caleb Eggensperger notifications@github.com
wrote:

I was actually just debugging a similar problem in our app, and I think
the best solution is either to only use transitions that you want ngAnimate
to care about (and then only use them in the special classes ng-animate
makes) or to use a prefix for ngAnimate:

https://docs.angularjs.org/api/ngAnimate#preventing-collisions-with-third-party-libraries

Though I don't know if it's possible to do that without enforcing it for
all angular-material users as well.


Reply to this email directly or view it on GitHub
#2663 (comment).

@robertmesserle
Copy link
Contributor

The easy fix is to add transition: none for md-toolbar.ng-animate
On Fri, May 1, 2015 at 4:58 PM Robert Messerle robert.messerle@gmail.com
wrote:

I well add a fix for this later. I've had to fix this on other components.
On Fri, May 1, 2015 at 3:29 PM Caleb Eggensperger <
notifications@github.com> wrote:

I was actually just debugging a similar problem in our app, and I think
the best solution is either to only use transitions that you want ngAnimate
to care about (and then only use them in the special classes ng-animate
makes) or to use a prefix for ngAnimate:

https://docs.angularjs.org/api/ngAnimate#preventing-collisions-with-third-party-libraries

Though I don't know if it's possible to do that without enforcing it for
all angular-material users as well.


Reply to this email directly or view it on GitHub
#2663 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
for: internal contributor The team will address this issue and community PRs are not requested. type: bug
Projects
None yet
Development

No branches or pull requests

4 participants