You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
The appendChip function in chipsController.js does some duplicate-checking to prevent adding the same chip multiple times. Unfortunately, it checks for matches before md-on-append is called. If md-on-append converts a string input into an object, for instance, the duplicate checking will always fail.
Presumably it should either check for duplicates after md-on-append has been called, or keep a separate collection of unmodified chips to check against.
The text was updated successfully, but these errors were encountered:
The duplicate check was firing before the user's onAppend
method had a chance to run, so the check would always
compare a string against an object and fail.
fixes#2748
The duplicate check was firing before the user's onAppend
method had a chance to run, so the check would always
compare a string against an object and fail.
fixes#2748
The duplicate check was firing before the user's onAppend
method had a chance to run, so the check would always
compare a string against an object and fail.
fixesangular#2748. closesangular#4113.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The appendChip function in chipsController.js does some duplicate-checking to prevent adding the same chip multiple times. Unfortunately, it checks for matches before md-on-append is called. If md-on-append converts a string input into an object, for instance, the duplicate checking will always fail.
Presumably it should either check for duplicates after md-on-append has been called, or keep a separate collection of unmodified chips to check against.
The text was updated successfully, but these errors were encountered: