Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Static chips should not have cursor text #3253

Closed
RomFouq opened this issue Jun 13, 2015 · 3 comments
Closed

Static chips should not have cursor text #3253

RomFouq opened this issue Jun 13, 2015 · 3 comments
Assignees
@typotter
Labels
pr: merge ready This PR is ready for a caretaker to review
Milestone
1.0-rc1

Comments

@RomFouq
Copy link

RomFouq commented Jun 13, 2015

Since they are static, they can't be edited or even selected, so they should have cursor default, not text.
This can be seen here:
https://material.angularjs.org/latest/#/demo/material.components.chips
When hovering between chips, a text cursor appears.
@chinnichaitanya
Copy link
Contributor

@RomFouq The cursor is default for me in the above link. I'm using chromium-browser 43.0

@RomFouq
Copy link
Author

RomFouq commented Jun 13, 2015

@chinnichaitanya
On chips, I agree, but not between chips and elsewhere on the md-chips element. I've tested this on Chromium and Firefox. This style is explicitly added by the .md-chips class, according to the inspector.

@ThomasBurleson ThomasBurleson modified the milestone: 0.11.0 Jul 6, 2015
@typotter
Copy link
Contributor

I would argue that in fact a static chip should have cursor:text since the text can be edited. But yes, the background/container element should not have cursor:text.

@typotter typotter added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Aug 11, 2015
typotter pushed a commit to typotter/material that referenced this issue Aug 11, 2015
fix(chips): cursor style on static chips
077ebbe 
Do not set the cursor style on the md-chips element if there are only static chips.
Also remove some TODO docs that have already been done.

fixes angular#3253
@typotter typotter mentioned this issue Aug 11, 2015
Closed
@typotter typotter added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs labels Aug 11, 2015
typotter pushed a commit to typotter/material that referenced this issue Aug 11, 2015
fix(chips): cursor style on static chips
13d0c9f 
Do not set the cursor style on the md-chips element if there are only static chips.
Also remove some TODO docs that have already been done.

fixes angular#3253
kennethcachia pushed a commit to kennethcachia/material that referenced this issue Sep 23, 2015
@kennethcachia
fix(chips): cursor style on static chips
72897bf 
Do not set the cursor style on the md-chips element if there are only static chips.
Also remove some TODO docs that have already been done.

fixes angular#3253. closes angular#4114.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@typotter typotter

Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
1.0-rc1
Development

Successfully merging a pull request may close this issue.

fix(chips): cursor style on static chips typotter/material
4 participants
@ThomasBurleson @RomFouq @chinnichaitanya @typotter