Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-chips: Unbalanced padding for chips that have no remove button #3276

Closed
blixt opened this issue Jun 15, 2015 · 0 comments
Closed

md-chips: Unbalanced padding for chips that have no remove button #3276

blixt opened this issue Jun 15, 2015 · 0 comments
Assignees
@typotter
Labels
pr: merge ready This PR is ready for a caretaker to review
Milestone
1.0-rc1

Comments

@blixt
Copy link

blixt commented Jun 15, 2015

screen shot 2015-06-15 at 6 22 47 pm

The right-hand side padding is 8px instead of 12px. This makes sense when there is a remove/X button, but when that button is not present, the chip appears unbalanced.
@ThomasBurleson ThomasBurleson modified the milestone: 0.11.0 Jul 6, 2015
topherfangio added a commit that referenced this issue Aug 21, 2015
@topherfangio
fix(chips): Fix styling issues with padding & remove.
37b6f2d 
Update SCSS to fix:
 * remove icon jumping to next line on long chips
 * right padding of chips without a remove icon
 * location of remove icon in Firefox/Safari

fixes #4264, fixes #3276, #2410
@topherfangio topherfangio mentioned this issue Aug 21, 2015
Closed
topherfangio added a commit that referenced this issue Aug 21, 2015
@topherfangio
fix(chips): Fix styling issues with padding & remove.
3676c90 
Update SCSS to fix:
 * remove icon jumping to next line on long chips
 * right padding of chips without a remove icon
 * location of remove icon in Firefox/Safari

fixes #4264, fixes #3276, fixes #2410
@topherfangio topherfangio added the pr: merge ready This PR is ready for a caretaker to review label Aug 21, 2015
kennethcachia pushed a commit to kennethcachia/material that referenced this issue Sep 23, 2015
@topherfangio @kennethcachia
fix(chips): Fix styling issues with padding & remove.
aed1338 
Update SCSS to fix:
 * remove icon jumping to next line on long chips
 * right padding of chips without a remove icon
 * location of remove icon in Firefox/Safari

fixes angular#4264. fixes angular#3276. fixes angular#2410. closes angular#4275.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@typotter typotter

Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
1.0-rc1
Development

Successfully merging a pull request may close this issue.

fix(chips): Fix styling issues with padding & remove. angular/material
4 participants
@topherfangio @blixt @ThomasBurleson @typotter