Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Readonly chips allows deletion with custom template #3697

Closed
stevenmiles opened this issue Jul 13, 2015 · 1 comment
Closed

Readonly chips allows deletion with custom template #3697

stevenmiles opened this issue Jul 13, 2015 · 1 comment
Assignees
@typotter
Labels
pr: merge ready This PR is ready for a caretaker to review type: bug
Milestone
1.0-rc1

Comments

@stevenmiles
Copy link

https://material.angularjs.org/HEAD/#/demo/material.components.chips

Check the Readonly checkbox under Basic Usage. The custom template example allows the items to be deleted.
@ThomasBurleson ThomasBurleson added the needs: review This PR is waiting on review from the team label Jul 31, 2015
@ThomasBurleson ThomasBurleson modified the milestone: REVISIT Jul 31, 2015
@ThomasBurleson ThomasBurleson assigned typotter and unassigned typotter Jul 31, 2015
@ThomasBurleson ThomasBurleson added needs: review This PR is waiting on review from the team and removed needs: review This PR is waiting on review from the team labels Jul 31, 2015
@typotter typotter added type: bug and removed needs: review This PR is waiting on review from the team labels Aug 10, 2015
@typotter
Copy link
Contributor

need to add an ng-if where the chip-remove template is transcluded in ChipsDirective.

@typotter typotter modified the milestones: 0.11.0, REVISIT Aug 10, 2015
@stevenmiles stevenmiles changed the title Readonly chips allows deletion witch custom template Readonly chips allows deletion with custom template Aug 10, 2015
typotter pushed a commit to typotter/material that referenced this issue Aug 10, 2015
fix(chips): hide remove button on custom template when readonly
a939944 
Add ng-if to the remove button, conditional on not readonly. Also tweak the custom input styling in the demo, and add the 'readonly' class to md-chip when it is readonly.

fixes angular#3697
@typotter typotter mentioned this issue Aug 10, 2015
Closed
@typotter typotter assigned typotter and unassigned topherfangio Aug 10, 2015
@typotter typotter added the pr: merge ready This PR is ready for a caretaker to review label Aug 11, 2015
typotter pushed a commit to typotter/material that referenced this issue Aug 11, 2015
fix(chips): hide remove button on custom template when readonly
99c68e0 
Add ng-if to the remove button, conditional on not readonly. Also tweak the custom input styling in the demo, and add the 'readonly' class to md-chip when it is readonly.

fixes angular#3697
kennethcachia pushed a commit to kennethcachia/material that referenced this issue Sep 23, 2015
@kennethcachia
fix(chips): hide remove button on custom template when readonly
77338e8 
Add ng-if to the remove button, conditional on not readonly. Also tweak the custom input styling in the demo, and add the 'readonly' class to md-chip when it is readonly.

fixes angular#3697. closes angular#4090.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@typotter typotter

Labels
pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Milestone
1.0-rc1
Development

Successfully merging a pull request may close this issue.

fix(chips): hide remove button on custom template when readonly typotter/material
4 participants
@topherfangio @ThomasBurleson @stevenmiles @typotter