This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(chips): cursor style on static chips #4114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jelbourn care to take a look? |
| @@ -55,7 +55,10 @@ $contact-chip-name-width: rem(12) !default; | |||
| font-size: $chip-font-size; | |||
| padding: $chip-wrap-padding; | |||
| vertical-align: middle; | |||
| cursor: text; | |||
|
|
|||
| &:not('.static-only') { | |||
There was a problem hiding this comment.
Should be md-static-only
Also, what do you think of instead naming it md-readonly ?
There was a problem hiding this comment.
actually readonly is a good idea. I have another PR that should use this style as well.
Updated. PTAL
Do not set the cursor style on the md-chips element if there are only static chips. Also remove some TODO docs that have already been done. fixes angular#3253
typotter
force-pushed
the
chips-fix-3253
branch
from
077ebbe to
13d0c9f
Compare
|
LGTM |
typotter
added
pr: merge ready
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
Do not set the cursor style on the md-chips element if there are only static chips. Also remove some TODO docs that have already been done. fixes angular#3253. closes angular#4114.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set the cursor style on the md-chips element if there are only static chips.
Also remove some TODO docs that have already been done.
fixes #3253