Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(fabToolbar): Fix md-direction attribute to be string instead of expression. #4185

Closed
wants to merge 1 commit into from

Conversation

topherfangio
Copy link
Contributor

The fabSpeedDial treats the md-direction attribute as a string as does the shared fabController. However, the fabToolbar treated it as an expression.

Update the code to make it a string instead.

fixes #3390

@topherfangio topherfangio added type: bug pr: merge ready This PR is ready for a caretaker to review labels Aug 15, 2015
@topherfangio topherfangio added this to the 0.11.0 milestone Aug 15, 2015
@topherfangio topherfangio added needs: review This PR is waiting on review from the team and removed pr: merge ready This PR is ready for a caretaker to review labels Aug 17, 2015
@topherfangio
Copy link
Contributor Author

@jelbourn Can you review real fast?

@ThomasBurleson
Copy link
Contributor

@topherfangio - can you provide a test to accompany these changes?

@ThomasBurleson ThomasBurleson added needs: tests in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs and removed needs: review This PR is waiting on review from the team labels Aug 18, 2015
@@ -65,7 +65,7 @@
'</div>',

scope: {
direction: '=?mdDirection',
direction: '@?mdDirection',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need unit test for this.

… expression.

Fix `md-direction` attribute to use the correct scope initialization.
@topherfangio topherfangio force-pushed the fix-fab-toolbar-direction branch from 14e998a to d7be7f4 Compare August 19, 2015 15:57
@topherfangio topherfangio added pr: merge ready This PR is ready for a caretaker to review and removed in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs needs: tests labels Aug 19, 2015
@topherfangio topherfangio deleted the fix-fab-toolbar-direction branch August 19, 2015 17:12
kennethcachia pushed a commit to kennethcachia/material that referenced this pull request Sep 23, 2015
… expression.

Fix `md-direction` attribute to use the correct scope initialization.

Fixes angular#3390. Closes angular#4185.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-fab-toolbar - strange margin
3 participants