This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(fabToolbar): Fix md-direction attribute to be string instead of expression. #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherfangio
added
type: bug
pr: merge ready
topherfangio
added
needs: review
|
@jelbourn Can you review real fast? |
|
@topherfangio - can you provide a test to accompany these changes? |
ThomasBurleson
added
needs: tests
in progress
| @@ -65,7 +65,7 @@ | |||
| '</div>', | |||
|
|
|||
| scope: { | |||
| direction: '=?mdDirection', | |||
| direction: '@?mdDirection', | |||
… expression. Fix `md-direction` attribute to use the correct scope initialization.
topherfangio
force-pushed
the
fix-fab-toolbar-direction
branch
from
14e998a
to
d7be7f4
Compare
topherfangio
added
pr: merge ready
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
… expression. Fix `md-direction` attribute to use the correct scope initialization. Fixes angular#3390. Closes angular#4185.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fabSpeedDial treats the
md-directionattribute as a string as does the shared fabController. However, the fabToolbar treated it as an expression.Update the code to make it a string instead.
fixes #3390