Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

ripple: TypeError on some components #4213

Closed
ngraef opened this issue Aug 18, 2015 · 5 comments
Closed

ripple: TypeError on some components #4213

ngraef opened this issue Aug 18, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@ngraef
Copy link
Contributor

ngraef commented Aug 18, 2015

After the recent refactor (e92dd26), checkbox, switch, and icon button ripples are broken. Other buttons, tabs, and select/menu item ripples still work.

Interacting with the broken elements gives

Uncaught TypeError: Cannot read property 'prop' of null

at ripple.js line 144.

cc: @robertmesserle

@stewones
Copy link

+1
here with md-menu

@sincraianul
Copy link

+1 same as @stewones

@Reklino
Copy link

Reklino commented Aug 19, 2015

Yep. Same issue.

I'm also having an issue where the ripples on other buttons are now out of place. The ripples seem to be originating from below the button and to the right. Not sure if it is related or not, but the issue seemed to start at the same time.

@rbluethl
Copy link

same issue on (md-icon inside) md-button

@ngraef
Copy link
Contributor Author

ngraef commented Aug 20, 2015

Looks like this was fixed by be4311a.

@ngraef ngraef closed this as completed Aug 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants