Bug in Icon buttons in the official site

[chinnichaitanya]

I get this error
Uncaught TypeError: Cannot read property 'prop' of null on clicking any icon button in the official site in current master branch.

Also, the alignment seems to be gone again. #4130

Browser - Chromium 43.0

Screen shot below

[ThomasBurleson]

@robertmesserle - Potential ripple.js issue in handleMousedown( ). Unable to reproduce with local build.

[Frank3K]

I think the error is at line 155 of ripple.js (be4311ac7e). this.container is undefined there.

[robertmesserle]

That shouldn’t be an issue anymore as container is a getter now
On Wed, Aug 19, 2015 at 12:12 PM Frank notifications@github.com wrote:

I think the error is at line 155 of ripple.js (be4311a)

material/src/core/services/ripple/ripple.js

Line 155 in be4311a

this.createRipple(this.container.prop('clientWidth') / 2, this.container.prop('clientWidth') / 2);

.
this.container is undefined there.

—
Reply to this email directly or view it on GitHub
#4244 (comment).

[ThomasBurleson]

@Frank3K - can you confirm this is fixed in the latest snapshot/master codebase ?

[bradmartin]

Couple of other issues ( #4224 & #4213 ) open related to this specific bug.

[bradmartin]

• v0.10.1-master-8c71d0c
  issue is present, just pulled from bower. Line 2970 angular-material.js throws the error. container is null.

Line 3017 of angular-material.js - InkRippleCtrl.prototype.createRipple. That's all the time I have tonight to provide some insight. I believe one of the other issues open reports other instances of the ripple not functioning normally.

[mckenzielong]

This is fixed in master. be4311a / valueOnUse code fixes it.

@ThomasBurleson Seems like the docs site hasn't been refreshed in a couple days though... did something break a build process somewhere? See: https://cdn.gitcdn.xyz/cdn/angular/bower-material/master/angular-material.js

Working plunk: http://plnkr.co/edit/f1ldRIpxWp7vEwEe5zjZ?p=preview

[Frank3K]

The ripple works for me in the Plunker by @mckenzielong. It indeed seems like the docs site does not use the latest version of material.

[bradmartin]

Or bower at the time I commented few hours ago

On 6:47am, Thu, Aug 20, 2015 Frank notifications@github.com wrote:

The ripple works for me in the Plunker by @mckenzielong
https://github.com/mckenzielong. It indeed seems like the docs site
does not use the latest version of material.

—
Reply to this email directly or view it on GitHub
#4244 (comment).

[ThomasBurleson]

@mckenzielong - The docs https://material.angularjs.org/HEAD/#/ are stale (not up-to-date). We are aware of this and hope to have this resolved today.

[bradmartin]

Seems to be fixed, bower pulled the latest commit.

[robertmesserle]

This is resolved now that the docs site is building again.