Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-subheader only works if at top of page #4420

Closed
clshortfuse opened this issue Sep 1, 2015 · 0 comments · Fixed by clshortfuse/material#10
Closed

md-subheader only works if at top of page #4420

clshortfuse opened this issue Sep 1, 2015 · 0 comments · Fixed by clshortfuse/material#10
Assignees
@topherfangio
Milestone
0.11.0

Comments

@clshortfuse
Copy link
Contributor

Here's the test/proof http://codepen.io/anon/pen/zvYJNB

It seems to keep traveling up through every parent

Edit: more analysis brings me to this line

Edit2: Since moving to v0.11, it also breaks toolbars that aren't at the top. Seems to be related to $mdSticky
@clshortfuse clshortfuse mentioned this issue Sep 1, 2015
Closed
@ThomasBurleson ThomasBurleson modified the milestones: 0.12.0, 0.11.0 Sep 1, 2015
topherfangio added a commit that referenced this issue Sep 2, 2015
@topherfangio
fix(mdSubheader): Non top-level md-content causes incorrect position.
382cd72 
If the subheader's parent `<md-content>` was not the top-level item,
the stickied subheader would be incorrectly positioned further down
the page.

Also added more tests to toolbar and fixed issue to ensure subheader
works with a toolbar using `md-scroll-shrink`.

Fixes #4420. References #2825.
@topherfangio topherfangio mentioned this issue Sep 2, 2015
Closed
@clshortfuse clshortfuse mentioned this issue Sep 2, 2015
Merged
topherfangio added a commit that referenced this issue Sep 3, 2015
@topherfangio
fix(mdSubheader): Non top-level md-content causes incorrect position.
0cf7438 
If the subheader's parent `<md-content>` was not the top-level item,
the stickied subheader would be incorrectly positioned further down
the page.

Also added more tests to toolbar and fixed issue to ensure subheader
works with a toolbar using `md-scroll-shrink`.

Fixes #4420. References #2825. Closes #4439.

Conflicts:
	src/components/toolbar/toolbar.js
	src/components/toolbar/toolbar.spec.js
kennethcachia pushed a commit to kennethcachia/material that referenced this issue Sep 23, 2015
@topherfangio @kennethcachia
fix(mdSubheader): Non top-level md-content causes incorrect position.
af10598 
If the subheader's parent `<md-content>` was not the top-level item,
the stickied subheader would be incorrectly positioned further down
the page.

Also added more tests to toolbar and fixed issue to ensure subheader
works with a toolbar using `md-scroll-shrink`.

Fixes angular#4420. References angular#2825. Closes angular#4439.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@topherfangio topherfangio

Labels
None yet
Projects
None yet
Milestone
0.11.0
3 participants
@topherfangio @ThomasBurleson @clshortfuse