Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

ProgressLinear: sync API with enhanced ProgressCircular #4421

Closed
ThomasBurleson opened this issue Sep 1, 2015 · 0 comments
Closed

ProgressLinear: sync API with enhanced ProgressCircular #4421

ThomasBurleson opened this issue Sep 1, 2015 · 0 comments
Assignees
@ThomasBurleson
Labels
type: enhancement
Milestone
1.0-rc1

Comments

@ThomasBurleson
Copy link
Contributor

We should update ProgressLinear to have the same performance improvements and API as the recently enhanced ProgressCircular.
@ThomasBurleson ThomasBurleson added this to the 0.12.0 milestone Sep 1, 2015
@ThomasBurleson ThomasBurleson self-assigned this Sep 1, 2015
ThomasBurleson added a commit that referenced this issue Sep 3, 2015
@ThomasBurleson
fix(progressLinear, progressCircular): sync logic, fix linear animati…
7991599 
…ons, perf upgrades

synchronize progressLinear with similar logic used in progressCircular.

* improve animation performances
* watch md-mode for changes
* refactor animation SCSS
* enable hiding and no-animations with undefined/empty md-mode attributes
* for both indicators, use `display:inline-block;`
* update demos with enable switch
* fix query mode
* update Select to use enhanced progressCircular component
* fix autocomplete styling of progress-linear.md-mode-indeterminate

BREAKING-CHANGES

Before:

```css
md-progress-linear {
  display: block;
}
md-progress-circular {
   // display not set
   // position not set
}
```

```css
md-progress-linear {
  display: inline-block;
  position: relative;
}
md-progress-circular {
  display: inline-block;
  position: relative;
}
```

Fixes #4421. Fixes #4409. Fixes #2540. Fixes #2364. Fixes #1926. Fixes #3802.
@ThomasBurleson ThomasBurleson mentioned this issue Sep 3, 2015
Closed
ThomasBurleson added a commit that referenced this issue Sep 3, 2015
@ThomasBurleson
fix(progressLinear, progressCircular): sync logic, fix linear animati…
8bf7a8b 
…ons, perf upgrades

synchronize progressLinear with similar logic used in progressCircular.

* improve animation performances
* watch md-mode for changes
* refactor animation SCSS
* enable hiding and no-animations with undefined/empty md-mode attributes
* for both indicators, use `display:inline-block;`
* update demos with enable switch
* fix query mode
* update Select to use enhanced progressCircular component
* fix autocomplete styling of progress-linear.md-mode-indeterminate
*  auto-inject md-mode attribute if missing
  *  use 'determinate' if value attribute is defined
  *  otherwise use 'indeterminate'
  *  $log.debug() notify user (via $log.debug) of injection
  *  add API doc details regarding md-mode auto-injection
* fix tests

BREAKING-CHANGES

Before:

```css
md-progress-linear {
  display: block;
}
md-progress-circular {
   // display not set
   // position not set
}
```

```css
md-progress-linear {
  display: inline-block;
  position: relative;
}
md-progress-circular {
  display: inline-block;
  position: relative;
}
```

Fixes #4421. Fixes #4409. Fixes #2540. Fixes #2364. Fixes #1926. Fixes #3802.
kennethcachia pushed a commit to kennethcachia/material that referenced this issue Sep 23, 2015
@ThomasBurleson @kennethcachia
fix(progressLinear, progressCircular): sync logic, fix linear animati…
97cb36b 
…ons, perf upgrades

synchronize progressLinear with similar logic used in progressCircular.

* improve animation performances
* watch md-mode for changes
* refactor animation SCSS
* enable hiding and no-animations with undefined/empty md-mode attributes
* for both indicators, use `display:inline-block;`
* update demos with enable switch
* fix query mode
* update Select to use enhanced progressCircular component
* fix autocomplete styling of progress-linear.md-mode-indeterminate
*  auto-inject md-mode attribute if missing
  *  use 'determinate' if value attribute is defined
  *  otherwise use 'indeterminate'
  *  $log.debug() notify user (via $log.debug) of injection
  *  add API doc details regarding md-mode auto-injection
* fix tests

BREAKING-CHANGES

Before:

```css
md-progress-linear {
  display: block;
}
md-progress-circular {
   // display not set
   // position not set
}
```

```css
md-progress-linear {
  display: block;
  position: relative;
}
md-progress-circular {
  display: block;
  position: relative;
}
```

Fixes angular#4421. Fixes angular#4409. Fixes angular#2540. Fixes angular#2364. Fixes angular#1926. Fixes angular#3802. Closes angular#4454.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

Labels
type: enhancement
Projects
None yet
Milestone
1.0-rc1
Development

Successfully merging a pull request may close this issue.

fix(progressLinear): sync logic, perf upgrades, fix animations angular/material
1 participant
@ThomasBurleson