Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Dialog keyHandlerFn fired after dialog close #5153

Closed
ericman93 opened this issue Oct 14, 2015 · 1 comment
Closed

Dialog keyHandlerFn fired after dialog close #5153

ericman93 opened this issue Oct 14, 2015 · 1 comment
Assignees
@ThomasBurleson

Comments

@ericman93
Copy link

When options.escapeToClose is assigned to true, even if the dialog is closed and the user hits 'Esc' key, keyHanlderFn fires anyway.
@ThomasBurleson ThomasBurleson self-assigned this Jan 5, 2016
@ThomasBurleson ThomasBurleson modified the milestone: Backlog Jan 5, 2016
@JasperG
Copy link

JasperG commented Jan 14, 2016

Also, in case where one dialog is opened where escapeToClose is true, any following dialog can still be closed by pressing the escape button, even when setting escapeToClose to false.

@JasperG JasperG mentioned this issue Feb 19, 2016
Closed
devversion added a commit to devversion/material that referenced this issue Feb 20, 2016
@devversion
fix(dialog): correctly disable keydown listener for escapeToClose
68f9ced 
Currently there was a duplicated variable `target`, which got replaced later and the `target` variable became the actual `element` not the `parent` anymore.

Fixes angular#7214 Fixes angular#5153
@devversion devversion mentioned this issue Feb 20, 2016
Closed
ThomasBurleson pushed a commit that referenced this issue Feb 26, 2016
@devversion @ThomasBurleson
fix(dialog): correctly disable keydown listener for escapeToClose
35de3d1 
Currently there was a duplicated variable `target`, which got replaced later and the `target` variable became the actual `element` not the `parent` anymore.

Fixes #7214 Fixes #5153

  Closes #7222
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ThomasBurleson @Splaktar @ericman93 @JasperG