Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Ripple 'sticks' if using UI Router in the app under certain conditions #5434

Closed
Todd-Werelius opened this issue Oct 29, 2015 · 7 comments · Fixed by #7965
Closed

Ripple 'sticks' if using UI Router in the app under certain conditions #5434

Todd-Werelius opened this issue Oct 29, 2015 · 7 comments · Fixed by #7965
Assignees
@devversion
Labels
has: Pull Request A PR has been created to address this issue P4: minor Minor issues. May not be fixed without community contributions. ui: ink

Comments

@Todd-Werelius
Copy link

This is an odd one, but since so many people use UI-Router it might be worth looking at

Possibly related to or interacts with #5294 #5046

To Reproduce ( Using Chrome + Windows 10 or Codpen Example )

  1. Click on a component that has a route attached using ui-sref
  2. Click outside the app ( another tab in browser or whatever)
  3. Click back inside the app, notice the ripple is now 'stuck' until you click something inside the app that can get focus

This gif loop probably explains it better ;-)

focus-problem
@fassetar
Copy link

+1 seeing it on windows 7 with chrome as well. Looks like md-focused is being added on the return.

@ThomasBurleson ThomasBurleson modified the milestone: 1.0-rc3 Nov 1, 2015
@EladBezalel EladBezalel modified the milestones: 1.0-rc4, 1.0-rc3 Nov 3, 2015
@EladBezalel
Copy link
Member

@devversion this might be close after you fix (#5589) will be merged am i right?

@devversion
Copy link
Member

Yes, your right, thanks for referencing that issue.

devversion added a commit to devversion/material that referenced this issue Nov 9, 2015
@devversion
feat(interaction): added service to detect last interaction
5dd246d 
Sidenav want's to restore focus after the pane gets closed, this should only happen for keyboard interactions.
The service got created to use that feature for other components too

Fixes angular#5563 Fixes angular#5434 Closes angular#5583 Closes angular#5589

feat(interaction): add test for interaction which fakes a keyboard input and validates it

test(interaction): add interaction spec for mousedown event + formats 4 spaces to 2

style(interaction): fix styling of the previous commits
@devversion devversion mentioned this issue Nov 9, 2015
Closed
devversion added a commit to devversion/material that referenced this issue Nov 11, 2015
@devversion
feat(interaction): added service to detect last interaction
29d4146 
Sidenav want's to restore focus after the pane gets closed, this should only happen for keyboard interactions.
The service got created to use that feature for other components too

Fixes angular#5563 Fixes angular#5434 Closes angular#5583 Closes angular#5589

feat(interaction): add test for interaction which fakes a keyboard input and validates it

test(interaction): add interaction spec for mousedown event + formats 4 spaces to 2

style(interaction): fix styling of the previous commits

test(sidenav): add sidenav focus restore test triggered by keyboard

test(sidenav): add focus restore test for mouse and patch other one

fix(sidenav): test
devversion added a commit to devversion/material that referenced this issue Nov 12, 2015
@devversion
feat(interaction): added service to detect last interaction
0cf58e4 
Sidenav want's to restore focus after the pane gets closed, this should only happen for keyboard interactions.
The service got created to use that feature for other components too

Fixes angular#5563 Fixes angular#5434 Closes angular#5583 Closes angular#5589

feat(interaction): add test for interaction which fakes a keyboard input and validates it

test(interaction): add interaction spec for mousedown event + formats 4 spaces to 2

style(interaction): fix styling of the previous commits

test(sidenav): add sidenav focus restore test triggered by keyboard

test(sidenav): add focus restore test for mouse and patch other one

fix(sidenav): test

fix(sidenav): replace deprecated methods, and remove aria label

test(sidenav): revert deprecated methods.
@EladBezalel EladBezalel modified the milestones: 1.0-rc5, 1.0-rc4 Nov 13, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc5, 1.0-rc7, 1.0-rc8 Nov 25, 2015
@EladBezalel EladBezalel mentioned this issue Dec 13, 2015
Closed
@ThomasBurleson ThomasBurleson removed this from the 1.0-rc8 milestone Jan 5, 2016
@devversion devversion added the pr: merge ready This PR is ready for a caretaker to review label Mar 28, 2016
devversion added a commit to devversion/material that referenced this issue Apr 7, 2016
@devversion
feat(interaction): added service to detect last interaction
28aa59a 
Fixes angular#5563 Fixes angular#5434 Closes angular#5583
devversion added a commit to devversion/material that referenced this issue Apr 9, 2016
@devversion
feat(interaction): added service to detect last interaction
e9faf66 
Fixes angular#5563 Fixes angular#5434 Closes angular#5583
@devversion devversion mentioned this issue Apr 9, 2016
Merged
@devversion devversion modified the milestones: Backlog, 1.1.3, 1.3.0 Apr 14, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.3.0, Backlog Apr 20, 2016
devversion added a commit to devversion/material that referenced this issue Apr 22, 2016
@devversion
feat(interaction): added service to detect last interaction
12f7f0f 
Fixes angular#5563 Fixes angular#5434 Closes angular#5583
@JaySardhara
Copy link

@Todd-Werelius, thanks for including GIF and raising issue.

@devversion facing similar issue for "md-radio-button" with "md-no-ink" flag set. I am getting ripple effect when tab loses focus and gains back again. Also this ripple effect stops after toggling radio buttons few times.
Not raising a new issue as this issue is pretty similar.

Thanks.

@ThomasBurleson ThomasBurleson added P4: minor Minor issues. May not be fixed without community contributions. and removed priority: low labels Jun 21, 2016
@devversion
Copy link
Member

@JaySardhara Yeah can see that. Once #7965 is ready, we should be able to fix this easily. Thanks for the ping

@JaySardhara
Copy link

@devversion that is great !!

@ThomasBurleson ThomasBurleson added has: Pull Request A PR has been created to address this issue and removed pr: merge ready This PR is ready for a caretaker to review labels Aug 24, 2016
@ThomasBurleson
Copy link
Contributor

FYI - merge of #7965 has been delayed until 1.1.2 or later.

devversion added a commit to devversion/material that referenced this issue Aug 26, 2016
@devversion
feat(interaction): added service to detect last interaction
7ea6489 
Fixes angular#5563 Fixes angular#5434 Closes angular#5583
devversion added a commit to devversion/material that referenced this issue Sep 19, 2016
@devversion
feat(interaction): added service to detect last interaction
8e8c6a6 
Fixes angular#5563 Fixes angular#5434 Closes angular#5583
kara pushed a commit that referenced this issue Oct 12, 2016
@devversion @kara
feat(interaction): added service to detect last interaction (#7965)
24370e7 
Fixes #5563 Fixes #5434 Closes #5583
@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
has: Pull Request A PR has been created to address this issue P4: minor Minor issues. May not be fixed without community contributions. ui: ink
Projects
None yet
Milestone
No milestone
7 participants
@ThomasBurleson @Splaktar @fassetar @devversion @Todd-Werelius @EladBezalel @JaySardhara