-
Notifications
You must be signed in to change notification settings - Fork 3.4k
BUG: getNearestContentElement in $mdUtil always returns root #5609
Comments
Isn't nodeName always in uppercase? |
yes I believe it should be, however it is not working and when I change it in source to lower case it works correctly. Using latest Chrome build. Looking at http://ejohn.org/blog/nodename-case-sensitivity/ it seems as if custom elements do not always follow the upper case rules. |
Adding a toUpperCase() on the left side should solve that issue. |
Custom elements do not always follow the upper case rules http://ejohn.org/blog/nodename-case-sensitivity/ fixes #5609
There are several issues out there (e.g. #2406) that point to tooltip positioning when the page is scrolled and getNearestContentElement that suggests that the enclosed loop is supposed to stop at md-content but does not. Adding that condition to the loop fixed the positioning issue for me. Fixes #2406. Closes #5161.
Custom elements do not always follow the upper case rules http://ejohn.org/blog/nodename-case-sensitivity/ fixes #5609
@EladBezalel This isn't working as expected. Replacing Tested in 1.0.0-rc5 |
@epelc thanks i will fix it. |
Thanks On Mon, Nov 30, 2015 at 4:27 PM, Elad Bezalel notifications@github.com
Thank you, |
@epelc do you have any idea why |
@EladBezalel I'm suspecting |
I have a number of tooltips in a nested md-content, the positioning is incorrect when the nearest md-content is scrolled. The offending issue is
getNearestContentElement
in $mdUtil.as
MD-CONTENT
is caps, it never matches the nearestmd-content
The text was updated successfully, but these errors were encountered: