Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

$mdDialog shouldn't emit a warning when there are no md-dialog-actions #5767

Closed
jelbourn opened this issue Nov 16, 2015 · 1 comment
Closed
Assignees
Labels
g3: reported The issue was reported by an internal or external product team. pr: merge ready This PR is ready for a caretaker to review
Milestone

Comments

@jelbourn
Copy link
Member

It is a valid use-case to have a dialog that you only close programmatically based on some user action. As such, there shouldn't be a warning when there are no md-dialog-actions present.

@EladBezalel is this something you could look at?

@jelbourn jelbourn added the g3: reported The issue was reported by an internal or external product team. label Nov 16, 2015
@jelbourn jelbourn added this to the 1.0-rc5 milestone Nov 16, 2015
@EladBezalel
Copy link
Member

@jelbourn fixed in #5774 PR

EladBezalel added a commit that referenced this issue Nov 16, 2015
It is a valid use-case to have a dialog that you only close programmatically based on some user action. As such, there shouldn't be a warning when there are no md-dialog-actions present.

fixes #5767
@EladBezalel EladBezalel added the pr: merge ready This PR is ready for a caretaker to review label Nov 16, 2015
EladBezalel added a commit that referenced this issue Nov 16, 2015
It is a valid use-case to have a dialog that you only close programmatically based on some user action. As such, there shouldn't be a warning when there are no md-dialog-actions present.

fixes #5767
EladBezalel added a commit that referenced this issue Nov 16, 2015
It is a valid use-case to have a dialog that you only close programmatically based on some user action. As such, there shouldn't be a warning when there are no md-dialog-actions present.

fixes #5767
EladBezalel added a commit that referenced this issue Nov 23, 2015
It is a valid use-case to have a dialog that you only close programmatically based on some user action. As such, there shouldn't be a warning when there are no md-dialog-actions present.

fixes #5767
EladBezalel added a commit that referenced this issue Nov 23, 2015
It is a valid use-case to have a dialog that you only close programmatically based on some user action. As such, there shouldn't be a warning when there are no md-dialog-actions present.

fixes #5767
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
g3: reported The issue was reported by an internal or external product team. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants