Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Slider gets too long if ng-model value goes higher than max #5872

Closed
defcronyke opened this issue Nov 22, 2015 · 5 comments
Closed

Slider gets too long if ng-model value goes higher than max #5872

defcronyke opened this issue Nov 22, 2015 · 5 comments
Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review

Comments

@defcronyke
Copy link

A text input and a material-slider share the same ng-model variable. The slider is set with a max value. Now if the input receives a value larger than the slider's max, the slider grows across the page. It's very ugly!

I would argue that the slider should not get longer, instead its marker should just go to the end of the bar.
@devversion
Copy link
Member

As always, I try to reproduce that issue. (http://codepen.io/DevVersion/pen/epobNq?editors=101).
Can you please review the codepen, everything is working well for me 👍

@defcronyke
Copy link
Author

You are using a number input. The problem happens when using a text input:

http://codepen.io/anon/pen/vNMvNZ

devversion added a commit to devversion/material that referenced this issue Nov 22, 2015
@devversion
fix(slider): use validators too if its numeric string
e884c4b 
Normally the numeric string will be applied to the model and the slider won't check for min and max.
This checks the strings too and validates for min and max

Before: http://codepen.io/anon/pen/vNMvNZ
After: http://codepen.io/DevVersion/pen/yYrGVW

Fixes angular#5872
@devversion devversion mentioned this issue Nov 22, 2015
Closed
@devversion
Copy link
Member

Thanks for that quick response 👍. Here is a Pull Request, which fixes that issue

@defcronyke
Copy link
Author

No thank you! :)

EladBezalel added a commit that referenced this issue Dec 22, 2015
@EladBezalel
feat(slider): vertical slider, range slider and UI fixes
8f7c254 
- Added vertical slider
- Added range sliders
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode

fixes #4371, #3259, #2421, #1221, #487
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Dec 27, 2015
@EladBezalel
feat(slider): vertical slider, range slider and UI fixes
d00dfaf 
- Added vertical slider
- Added range sliders
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #487, #4576
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Dec 27, 2015
@EladBezalel
feat(slider): vertical slider, range slider and UI fixes
5c326ec 
- Added vertical slider
- Added range sliders
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #487, #4576
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Dec 27, 2015
@EladBezalel
feat(slider): vertical slider, range slider and UI fixes
9df5596 
- Added vertical slider
- Added range sliders
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #487, #4576
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Dec 27, 2015
@EladBezalel
feat(slider): vertical slider, range slider and UI fixes
53528fd 
- Added vertical slider
- Added range sliders
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #487, #4576
closes #5874, #5872, #6051
@EladBezalel EladBezalel added the pr: merge ready This PR is ready for a caretaker to review label Jan 9, 2016
@EladBezalel EladBezalel mentioned this issue Jan 9, 2016
Closed
@ThomasBurleson ThomasBurleson added the P1: urgent Urgent issues that should be addressed in the next minor or patch release. label Jan 14, 2016
@ThomasBurleson ThomasBurleson modified the milestone: Backlog Jan 14, 2016
EladBezalel added a commit that referenced this issue Feb 4, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
0727cfc 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 5, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
e04dd2c 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 6, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
81bae90 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 26, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
55673f4 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 26, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
1692813 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 26, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
4d4691a 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 26, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
0f41386 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 26, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
f1b7529 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Made value rounding to 6 zeros after the dot
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 27, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
c176251 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation.
- Made input width grow or shrink according the text length
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093
closes #5874, #5872, #6051
EladBezalel added a commit that referenced this issue Feb 27, 2016
@EladBezalel
feat(slider): vertical slider, UI fixes and bug fixes
914b35b 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation.
- Made input width grow or shrink according the text length
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093
closes #5874, #5872, #6051
ThomasBurleson pushed a commit that referenced this issue Mar 2, 2016
@EladBezalel @ThomasBurleson
feat(slider): vertical slider, UI fixes and bug fixes
e0abeb4 
- Added vertical slider
- Improved UI
- Fixed dynamic min/max with values not in range
- Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation.
- Made input width grow or shrink according the text length
- Added discrete readonly mode
- Added disabled on slider container

fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093
closes #5874, #5872, #6051
@ThomasBurleson
Copy link
Contributor

Fixed with SHA e0abeb4

@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ThomasBurleson @defcronyke @Splaktar @devversion @EladBezalel